Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Issue 15734002: Add pretenuring support to HAllocateObject. (Closed)

Created:
7 years, 7 months ago by Hannes Payer (out of office)
Modified:
7 years, 6 months ago
CC:
v8-dev
Visibility:
Public.

Description

Add pretenuring support to HAllocateObject. BUG=

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+106 lines, -16 lines) Patch
M src/arm/lithium-codegen-arm.cc View 1 2 3 chunks +13 lines, -3 lines 0 comments Download
M src/flag-definitions.h View 1 2 1 chunk +1 line, -0 lines 1 comment Download
M src/hydrogen.cc View 1 2 3 1 chunk +9 lines, -1 line 0 comments Download
M src/hydrogen-instructions.h View 1 2 3 4 chunks +28 lines, -3 lines 1 comment Download
M src/ia32/lithium-codegen-ia32.cc View 1 2 3 chunks +16 lines, -5 lines 0 comments Download
M src/x64/lithium-codegen-x64.cc View 1 2 3 chunks +13 lines, -4 lines 0 comments Download
M test/cctest/test-heap.cc View 1 2 3 4 1 chunk +26 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Hannes Payer (out of office)
https://codereview.chromium.org/15734002/diff/8001/src/flag-definitions.h File src/flag-definitions.h (right): https://codereview.chromium.org/15734002/diff/8001/src/flag-definitions.h#newcode196 src/flag-definitions.h:196: DEFINE_bool(pretenure_hallocateobject, false, "pretenure HAllocateObject") This currently tanks performance. We ...
7 years, 7 months ago (2013-05-23 09:32:27 UTC) #1
mvstanton
Hi Hannes, lgtm, though one comment, see if it's addressable. https://codereview.chromium.org/15734002/diff/8001/src/hydrogen-instructions.h File src/hydrogen-instructions.h (right): https://codereview.chromium.org/15734002/diff/8001/src/hydrogen-instructions.h#newcode4878 ...
7 years, 7 months ago (2013-05-23 12:47:46 UTC) #2
Michael Starzinger
As discussed offline: I don't think we should put more work into HAllocateObject but rather ...
7 years, 7 months ago (2013-05-23 14:50:18 UTC) #3
Hannes Payer (out of office)
7 years, 7 months ago (2013-05-23 15:02:08 UTC) #4
On 2013/05/23 14:50:18, Michael Starzinger wrote:
> As discussed offline: I don't think we should put more work into
HAllocateObject
> but rather get rid of it and model it using HAllocate and a sequence if
> HStoreNamedField instructions. This would reduce complexity.

I agree, we should get rid of it.

Powered by Google App Engine
This is Rietveld 408576698