Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issue 1573383002: Couple of small cleanups to MessagePumpMojo. (Closed)

Created:
4 years, 11 months ago by Anand Mistry (off Chromium)
Modified:
4 years, 11 months ago
Reviewers:
sky
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Small set of cleanups to MessagePumpMojo. These are: 1. Change RemoveInvalidHandle to SignalHandleError to mirror SignalHandleReady. 2. Use SignalHandleError wherever handler->OnHandleError is called. Committed: https://crrev.com/edd0504f025875837561cdc2a71a9939b8479504 Cr-Commit-Position: refs/heads/master@{#369389}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -29 lines) Patch
M mojo/message_pump/message_pump_mojo.h View 2 chunks +5 lines, -4 lines 0 comments Download
M mojo/message_pump/message_pump_mojo.cc View 4 chunks +18 lines, -25 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
Anand Mistry (off Chromium)
No behaviour changes. Just a bit of consistency and code re-use cleanup.
4 years, 11 months ago (2016-01-13 22:29:15 UTC) #2
sky
LGTM
4 years, 11 months ago (2016-01-14 00:16:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1573383002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1573383002/1
4 years, 11 months ago (2016-01-14 00:34:19 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_dbg_recipe on tryserver.chromium.android (JOB_TIMED_OUT, no build URL) android_chromium_gn_compile_dbg on ...
4 years, 11 months ago (2016-01-14 02:39:08 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1573383002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1573383002/1
4 years, 11 months ago (2016-01-14 10:46:34 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-14 10:51:00 UTC) #10
commit-bot: I haz the power
4 years, 11 months ago (2016-01-14 10:52:22 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/edd0504f025875837561cdc2a71a9939b8479504
Cr-Commit-Position: refs/heads/master@{#369389}

Powered by Google App Engine
This is Rietveld 408576698