Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(395)

Issue 1573363002: [parser cleanup] Unify implementation of CheckPossibleEvalCall (Closed)

Created:
4 years, 11 months ago by adamk
Modified:
4 years, 11 months ago
Reviewers:
Dan Ehrenberg
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[parser cleanup] Unify implementation of CheckPossibleEvalCall Besides reducing code duplication, this makes it easier to change the implementation, which may be necessary to properly support eval calls in arrow function parameter initializers. Committed: https://crrev.com/1be3c3a2ae87b994df5f6a191feca231cd83f242 Cr-Commit-Position: refs/heads/master@{#33219}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -24 lines) Patch
M src/parsing/parser.h View 1 chunk +0 lines, -5 lines 0 comments Download
M src/parsing/parser.cc View 1 chunk +0 lines, -11 lines 0 comments Download
M src/parsing/parser-base.h View 1 chunk +11 lines, -0 lines 0 comments Download
M src/parsing/preparser.h View 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
adamk
4 years, 11 months ago (2016-01-11 22:48:41 UTC) #2
Dan Ehrenberg
lgtm
4 years, 11 months ago (2016-01-11 23:20:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1573363002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1573363002/1
4 years, 11 months ago (2016-01-11 23:22:17 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-11 23:36:24 UTC) #6
commit-bot: I haz the power
4 years, 11 months ago (2016-01-11 23:36:33 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1be3c3a2ae87b994df5f6a191feca231cd83f242
Cr-Commit-Position: refs/heads/master@{#33219}

Powered by Google App Engine
This is Rietveld 408576698