Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 1573333002: [Media Router] Add remaining First Run Flow strings. (Closed)

Created:
4 years, 11 months ago by apacible
Modified:
4 years, 11 months ago
Reviewers:
imcheng
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Media Router] Add remaining First Run Flow strings. Part 3 of several. Adds Chrome specific strings, which are gated to Chrome branded builds. BUG=560457 Committed: https://crrev.com/5377f6705b669752680eb425dca27cbd60b31809 Cr-Commit-Position: refs/heads/master@{#369337}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -6 lines) Patch
M chrome/app/media_router_strings.grdp View 1 chunk +22 lines, -6 lines 0 comments Download
M chrome/browser/ui/webui/media_router/media_router_localized_strings_provider.cc View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (12 generated)
apacible
PTAL, thanks!
4 years, 11 months ago (2016-01-13 22:22:55 UTC) #6
imcheng
lgtm
4 years, 11 months ago (2016-01-14 01:54:27 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1573333002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1573333002/40001
4 years, 11 months ago (2016-01-14 01:59:12 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/101639) linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED, ...
4 years, 11 months ago (2016-01-14 02:39:07 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1573333002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1573333002/40001
4 years, 11 months ago (2016-01-14 04:45:02 UTC) #15
commit-bot: I haz the power
Committed patchset #1 (id:40001)
4 years, 11 months ago (2016-01-14 05:30:36 UTC) #17
commit-bot: I haz the power
4 years, 11 months ago (2016-01-14 05:32:30 UTC) #19
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5377f6705b669752680eb425dca27cbd60b31809
Cr-Commit-Position: refs/heads/master@{#369337}

Powered by Google App Engine
This is Rietveld 408576698