Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1573323002:
[Chromecast] Don't use system libexpat. (Closed)
Description[Chromecast] Don't use system libexpat.
BUG= internal b/26249831
TEST= Builds and runs.
Committed: https://crrev.com/30b1385e4732ff1d1a01073a814284b557f25833
Cr-Commit-Position: refs/heads/master@{#368756}
Patch Set 1 #
Total comments: 5
Patch Set 2 : Style fixes. #Patch Set 3 : Add GN change. #
Total comments: 1
Patch Set 4 : Added comment for GN chromecast case. #
Messages
Total messages: 24 (9 generated)
Description was changed from ========== [Chromecast] Don't use system libexpat. BUG= internal b/26249831 TEST= Builds and runs. ========== to ========== [Chromecast] Don't use system libexpat. BUG= internal b/26249831 TEST= Builds and runs. ==========
bcf@chromium.org changed reviewers: + slan@chromium.org, wzhong@chromium.org
https://codereview.chromium.org/1573323002/diff/1/third_party/expat/expat.gyp File third_party/expat/expat.gyp (right): https://codereview.chromium.org/1573323002/diff/1/third_party/expat/expat.gyp... third_party/expat/expat.gyp:10: ['os_posix == 1 and OS != "mac" and OS != "ios" and OS != "android" and \ Is '\' commonly used on gyp file? https://codereview.chromium.org/1573323002/diff/1/third_party/expat/expat.gyp... third_party/expat/expat.gyp:11: chromecast!=1', { Spaces around !=. https://codereview.chromium.org/1573323002/diff/1/third_party/expat/expat.gyp... third_party/expat/expat.gyp:70: ['OS=="mac" or OS=="ios" or OS=="android" or os_bsd==1 or chromecast==1', { Ditto.
https://codereview.chromium.org/1573323002/diff/1/third_party/expat/expat.gyp File third_party/expat/expat.gyp (right): https://codereview.chromium.org/1573323002/diff/1/third_party/expat/expat.gyp... third_party/expat/expat.gyp:10: ['os_posix == 1 and OS != "mac" and OS != "ios" and OS != "android" and \ On 2016/01/11 21:53:34, wzhong wrote: > Is '\' commonly used on gyp file? I just let the line be longer that 80c because that seems to be common in other files. https://codereview.chromium.org/1573323002/diff/1/third_party/expat/expat.gyp... third_party/expat/expat.gyp:11: chromecast!=1', { On 2016/01/11 21:53:34, wzhong wrote: > Spaces around !=. I removed the spaces because that seems to be more consistent with other files.
On 2016/01/11 23:02:07, bcf wrote: > https://codereview.chromium.org/1573323002/diff/1/third_party/expat/expat.gyp > File third_party/expat/expat.gyp (right): > > https://codereview.chromium.org/1573323002/diff/1/third_party/expat/expat.gyp... > third_party/expat/expat.gyp:10: ['os_posix == 1 and OS != "mac" and OS != "ios" > and OS != "android" and \ > On 2016/01/11 21:53:34, wzhong wrote: > > Is '\' commonly used on gyp file? > > I just let the line be longer that 80c because that seems to be common in other > files. > > https://codereview.chromium.org/1573323002/diff/1/third_party/expat/expat.gyp... > third_party/expat/expat.gyp:11: chromecast!=1', { > On 2016/01/11 21:53:34, wzhong wrote: > > Spaces around !=. > > I removed the spaces because that seems to be more consistent with other files. GYP looks good 2 me, please also add the GN change.
lgtm Please request review by OWNERS.
bcf@chromium.org changed reviewers: + brettw@chromium.org
On 2016/01/11 23:17:15, wzhong wrote: > lgtm > > Please request review by OWNERS. + brettw@ for OWNERS
lgtm
+mbjorge for FYI
lgtm https://codereview.chromium.org/1573323002/diff/40001/third_party/expat/BUILD.gn File third_party/expat/BUILD.gn (right): https://codereview.chromium.org/1573323002/diff/40001/third_party/expat/BUILD... third_party/expat/BUILD.gn:7: if (is_linux && !is_chromecast) { Can this have a comment about why the checked-in expat should be used by Chromecast? Just something like "Chromecast doesn't ship expat as a system library" would be sufficient.
The CQ bit was checked by bcf@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1573323002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1573323002/60001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by bcf@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from wzhong@chromium.org, slan@chromium.org, brettw@chromium.org Link to the patchset: https://codereview.chromium.org/1573323002/#ps60001 (title: "Added comment for GN chromecast case.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1573323002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1573323002/60001
Message was sent while issue was closed.
Description was changed from ========== [Chromecast] Don't use system libexpat. BUG= internal b/26249831 TEST= Builds and runs. ========== to ========== [Chromecast] Don't use system libexpat. BUG= internal b/26249831 TEST= Builds and runs. ==========
Message was sent while issue was closed.
Committed patchset #4 (id:60001)
Message was sent while issue was closed.
Description was changed from ========== [Chromecast] Don't use system libexpat. BUG= internal b/26249831 TEST= Builds and runs. ========== to ========== [Chromecast] Don't use system libexpat. BUG= internal b/26249831 TEST= Builds and runs. Committed: https://crrev.com/30b1385e4732ff1d1a01073a814284b557f25833 Cr-Commit-Position: refs/heads/master@{#368756} ==========
Message was sent while issue was closed.
Patchset 4 (id:??) landed as https://crrev.com/30b1385e4732ff1d1a01073a814284b557f25833 Cr-Commit-Position: refs/heads/master@{#368756} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
