Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 1573303002: Fix mash shelf height. (Closed)

Created:
4 years, 11 months ago by msw
Modified:
4 years, 11 months ago
Reviewers:
sky
CC:
chromium-reviews, kalyank, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix mash shelf height. It was set to the height of the container (desktop). Use the preferred size height instead. BUG=557406 TEST=NONE R=sky@chromium.org Committed: https://crrev.com/8ec24a04742bd3833129d3b6537fbd2fc89f95f4 Cr-Commit-Position: refs/heads/master@{#368707}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M mash/wm/shelf_layout.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
msw
Hey Scott, please take a look; thanks!
4 years, 11 months ago (2016-01-11 20:55:18 UTC) #1
sky
LGTM
4 years, 11 months ago (2016-01-11 21:13:15 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1573303002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1573303002/1
4 years, 11 months ago (2016-01-11 22:20:41 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-11 23:14:29 UTC) #5
commit-bot: I haz the power
4 years, 11 months ago (2016-01-11 23:15:51 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8ec24a04742bd3833129d3b6537fbd2fc89f95f4
Cr-Commit-Position: refs/heads/master@{#368707}

Powered by Google App Engine
This is Rietveld 408576698