net/dns/record_parsed.h - Issue 15733008: Multicast DNS implementation (initial)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/dns/record_parsed.h

Issue 15733008: Multicast DNS implementation (initial) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@mdns_implementation2

Patch Set: Uploading to check comments against diff (next upload will have files renamed) Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/dns/record_parsed.h

diff --git a/net/dns/record_parsed.h b/net/dns/record_parsed.h

index 5d35ff319bbed0cae39b5b44757ada6a06e5f5da..d8738521fd3c73dc516f5aefb8fa5d89fee6f85b 100644

--- a/net/dns/record_parsed.h

+++ b/net/dns/record_parsed.h

@@ -25,6 +25,7 @@ class NET_EXPORT_PRIVATE RecordParsed {

// All records are inherently immutable. Return a const pointer.

static scoped_ptr<const RecordParsed> CreateFrom(DnsRecordParser* parser,

base::Time time_created);

+ scoped_ptr<const RecordParsed> Clone() const;

const std::string& name() const { return name_; }

uint16 type() const { return type_; }

@@ -49,7 +50,7 @@ class NET_EXPORT_PRIVATE RecordParsed {

uint32 ttl, scoped_ptr<const RecordRdata> rdata,

base::Time time_created);

- std::string name_; // in dotted form

+ const std::string name_; // in dotted form

const uint16 type_;

const uint16 klass_;

const uint32 ttl_;