Issue 15733007: use Descriptor struct to encapsulate all the common paramaeters between our various gradient types.…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 15733007: use Descriptor struct to encapsulate all the common paramaeters between our various gradient types.… (Closed)

Created:
7 years, 7 months ago by reed1

Modified:
7 years, 7 months ago

Reviewers:
bsalomon

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

use Descriptor struct to encapsulate all the common paramaeters between our various gradient types. If we like it, might promote it to the public API. BUG= R=bsalomon@google.com Committed: https://code.google.com/p/skia/source/detail?r=9260

Patch Set 1 #

Total comments: 1

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+86 lines, -71 lines)			Patch
M	src/effects/gradients/SkGradientShader.cpp	View	11 chunks	+52 lines, -35 lines	0 comments	Download
M	src/effects/gradients/SkGradientShaderPriv.h	View	1 chunk	+15 lines, -2 lines	0 comments	Download
M	src/effects/gradients/SkLinearGradient.h	View	1 chunk	+1 line, -3 lines	0 comments	Download
M	src/effects/gradients/SkLinearGradient.cpp	View	1 chunk	+2 lines, -7 lines	0 comments	Download
M	src/effects/gradients/SkRadialGradient.h	View	1 chunk	+1 line, -2 lines	1 comment	Download
M	src/effects/gradients/SkRadialGradient.cpp	View	1 chunk	+2 lines, -3 lines	0 comments	Download
M	src/effects/gradients/SkSweepGradient.h	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	src/effects/gradients/SkSweepGradient.cpp	View	1 chunk	+6 lines, -3 lines	0 comments	Download
M	src/effects/gradients/SkTwoPointConicalGradient.h	View	1 chunk	+1 line, -3 lines	0 comments	Download
M	src/effects/gradients/SkTwoPointConicalGradient.cpp	View	1 chunk	+2 lines, -4 lines	0 comments	Download
M	src/effects/gradients/SkTwoPointRadialGradient.h	View	1 chunk	+1 line, -3 lines	0 comments	Download
M	src/effects/gradients/SkTwoPointRadialGradient.cpp	View	1 chunk	+2 lines, -4 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

bsalomon

lgtm https://codereview.chromium.org/15733007/diff/1/src/effects/gradients/SkRadialGradient.h File src/effects/gradients/SkRadialGradient.h (right): https://codereview.chromium.org/15733007/diff/1/src/effects/gradients/SkRadialGradient.h#newcode17 src/effects/gradients/SkRadialGradient.h:17: const Descriptor&); align consts?

7 years, 7 months ago (2013-05-23 18:24:56 UTC) #2

reed1

7 years, 7 months ago (2013-05-23 19:03:12 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r9260 (presubmit successful).

Expand Messages | Collapse Messages