scripts/slave/recipes/bisect.py - Issue 1573293002: Change auto_bisect to post results to perf dashboard.

Unified Diff: scripts/slave/recipes/bisect.py

Issue 1573293002: Change auto_bisect to post results to perf dashboard. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master

Patch Set: post_bisect to post_bisect_results Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« scripts/slave/recipe_modules/perf_try/api.py ('K') | « scripts/slave/recipe_modules/perf_try/api.py ('k') | scripts/slave/recipes/bisect.expected/basic.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: scripts/slave/recipes/bisect.py

diff --git a/scripts/slave/recipes/bisect.py b/scripts/slave/recipes/bisect.py

index 52dbf25dd5d601a50945547a49878a78cd046b47..ac2ea69baa169e9858a9d6b0e0074ca8798efbce 100644

--- a/scripts/slave/recipes/bisect.py

+++ b/scripts/slave/recipes/bisect.py

@@ -142,6 +142,7 @@ def GenTests(api):

for step_data in _get_step_data_for_revision(api, revision_data):

basic_test += step_data

basic_test += _get_revision_range_step_data(api, basic_test_data)

+ basic_test += _get_post_bisect_step_data(api)

yield basic_test

broken_test_data = test_data()

@@ -158,6 +159,7 @@ def GenTests(api):

skip_results=skip_results):

broken_bad_rev_test += step_data

broken_bad_rev_test += _get_revision_range_step_data(api, doctored_data)

+ broken_bad_rev_test += _get_post_bisect_step_data(api)

yield broken_bad_rev_test

doctored_data = test_data()

@@ -169,6 +171,7 @@ def GenTests(api):

skip_results=skip_results):

broken_good_rev_test += step_data

broken_good_rev_test += _get_revision_range_step_data(api, doctored_data)

+ broken_good_rev_test += _get_post_bisect_step_data(api)

yield broken_good_rev_test

def return_code_test_data():

@@ -241,6 +244,7 @@ def GenTests(api):

for step_data in _get_step_data_for_revision(api, revision_data):

return_code_test += step_data

return_code_test += _get_revision_range_step_data(api, return_code_test_data)

+ return_code_test += _get_post_bisect_step_data(api)

yield return_code_test

@@ -277,13 +281,21 @@ def _get_step_data_for_revision(api, revision_data, broken_cp=None,

if not skip_results:

step_name = 'gsutil Get test results for build ' + commit_hash

if 'refrange' in revision_data:

- step_name = 'Gathering reference values.' + step_name

+ parent_step = 'Gathering reference values.'

else:

- step_name = 'Working on revision %s.' % commit_hash + step_name

- yield api.step_data(step_name, stdout=api.raw_io.output(json.dumps(

- test_results)))

+ parent_step = 'Working on revision %s.' % commit_hash

+ yield _get_post_bisect_step_data(api, parent_step)

+ yield api.step_data(parent_step + step_name,

+ stdout=api.raw_io.output(json.dumps(test_results)))

if 'cl_info' in revision_data:

step_name = 'Reading culprit cl information.'

stdout = api.json.output(revision_data['cl_info'])

yield api.step_data(step_name, stdout=stdout)

+def _get_post_bisect_step_data(api, parent_step=''):

+ """Gets step data for perf_dashboard/resource/post_json.py."""

+ response = {'status_code': 200}

+ return api.step_data(parent_step + 'Post bisect results',

+ stdout=api.json.output(response))

qyearsley 2016/01/26 22:10:50 Style nit: when there are arguments on the same li