Change auto_bisect to post results to perf dashboard.

scripts/slave/recipe_modules/auto_bisect/bisector.py

 # Copyright 2015 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import json
 import re
 
-from . import bisect_results
+from . import bisect_results_json
 from . import depot_config
 from . import revision_state
 
 _DEPS_SHA_PATCH = """
 diff --git DEPS.sha DEPS.sha
 new file mode 100644
 --- /dev/null
 +++ DEPS.sha
 @@ -0,0 +1 @@
 +%(deps_sha)s
@@ skipping 438 matching lines @@
     result += 'bisector.fkbr: %r\n\n' % self.fkbr
     result += self._revision_value_table()
     if (self.lkgr and self.lkgr.values and self.fkbr and self.fkbr.values):
       result += '\n' + self._t_test_results()
     return result
 
   def _revision_value_table(self):
     """Returns a string table showing revisions and their values."""
     header = [['Revision', 'Values']]
     rows = [[str(r.commit_pos), str(r.values)] for r in self.revisions]
-    return bisect_results.pretty_table(header + rows)
+    return self._pretty_table(header + rows)
+
+  def _pretty_table(self, data):
+    results = []
+    for row in data:
+      results.append('%-15s' * len(row) % tuple(row))
+    return '\n'.join(results)
 
   def _t_test_results(self):
     """Returns a string showing t-test results for lkgr and fkbr."""
     t, df, p = self.api.m.math_utils.welchs_t_test(
         self.lkgr.values, self.fkbr.values)
     lines = [
         'LKGR values: %r' % self.lkgr.values,
         'FKBR values: %r' % self.fkbr.values,
         't-statistic: %r' % t,
         'deg. of freedom:  %r' % df,
         'p-value: %r' % p,
         'Confidence score: %r' % (100 * (1 - p))
     ]
     return '\n'.join(lines)
 
-  def partial_results(self):
-    return bisect_results.BisectResults(self, partial=True).as_string()
-
   def print_result_debug_info(self):
     """Prints extra debug info at the end of the bisect process."""
     lines = self._results_debug_message().splitlines()
     # If we emit a null step then add a log to it, the log should be kept
     # longer than 7 days (which is often needed to debug some issues).
     self.api.m.step('Debug Info', [])
     self.api.m.step.active_result.presentation.logs['Debug Info'] = lines
 
-  def print_result(self):
-    results = bisect_results.BisectResults(self).as_string()
-    self.api.m.python.inline(
-        'Results',
-        """
-        import shutil
-        import sys
-        shutil.copyfileobj(open(sys.argv[1]), sys.stdout)
-        """,
-        args=[self.api.m.raw_io.input(data=results)])
+  def post_result(self, halt_on_failure=False):
+    """Posts bisect results to Perf Dashboard."""
+    results = bisect_results_json.get(self)
+    self.api.m.perf_dashboard.set_default_config()
+    self.api.m.perf_dashboard.post_bisect(results, halt_on_failure)

[qyearsley, 2016/01/11 22:49:43]

Nice, I'm glad we can re-use the perf_dashboard recipe module.

 
   def get_revision_to_eval(self):
     """Gets the next RevistionState object in the candidate range.
 
     Returns:
        The next Revision object in a list.
     """
     self._update_candidate_range()
     candidate_range = [revision for revision in
                        self.revisions[self.lkgr.list_index + 1:
@@ skipping 270 matching lines @@
 
   def surface_result(self, result_string):
     assert result_string in VALID_RESULT_CODES
     prefix = 'B4T_'  # To avoid collision. Stands for bisect (abbr. `a la i18n).
     result_code = prefix + result_string
     assert len(result_code) <= 20
     if result_code not in self.result_codes:
       self.result_codes.add(result_code)
       properties = self.api.m.step.active_result.presentation.properties
       properties['extra_result_code'] = sorted(self.result_codes)
-