third_party/WebKit/Source/platform/scheduler/CancellableTaskFactory.h - Issue 1573283004: Oilpan: provide a weak 'this' pointer abstraction for cancellable closures.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/scheduler/CancellableTaskFactory.h

Issue 1573283004: Oilpan: provide a weak 'this' pointer abstraction for cancellable closures. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add comments + TODOs Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/platform/scheduler/CancellableTaskFactory.h

diff --git a/third_party/WebKit/Source/platform/scheduler/CancellableTaskFactory.h b/third_party/WebKit/Source/platform/scheduler/CancellableTaskFactory.h

index 935ddadcd95d3ecdbc0d310d79c9a30a096fcfd1..5d8a597fa6308d679f2f46250c7543b320ffd6ea 100644

--- a/third_party/WebKit/Source/platform/scheduler/CancellableTaskFactory.h

+++ b/third_party/WebKit/Source/platform/scheduler/CancellableTaskFactory.h

@@ -40,7 +40,7 @@ public:

template<typename T>

static PassOwnPtr<CancellableTaskFactory> create(T* thisObject, void (T::*method)(), typename std::enable_if<IsGarbageCollectedType<T>::value>::type* = nullptr)

{

- return adoptPtr(new CancellableTaskFactory(WTF::bind(method, AllowCrossThreadWeakPersistent<T>(thisObject))));

+ return adoptPtr(new CancellableTaskFactory(WTF::bind(method, CrossThreadWeakPersistentThisPointer<T>(thisObject))));

}

template<typename T>

« no previous file with comments | « third_party/WebKit/Source/platform/heap/Handle.h ('k') | no next file » | no next file with comments »