Issue 1573283003: Add a new 'summary' performance tag.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1573283003: Add a new 'summary' performance tag. (Closed)

Created:
4 years, 11 months ago by scheglov

Modified:
4 years, 11 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Add a new 'summary' performance tag. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/925458da82763fe0fef55a525a02b5dc964d3846

Patch Set 1 #

Created: 4 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+29 lines, -22 lines)			Patch
	M	pkg/analyzer/lib/src/context/context.dart	View		2 chunks	+21 lines, -19 lines	0 comments	Download
	M	pkg/analyzer/lib/src/generated/engine.dart	View		4 chunks	+8 lines, -3 lines	0 comments	Download

Messages

Total messages: 5 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Brian Wilkerson

LGTM. We should get this on the status pages and make sure that it will ...

4 years, 11 months ago (2016-01-12 00:01:44 UTC) #2

scheglov

Committed patchset #1 (id:1) manually as 925458da82763fe0fef55a525a02b5dc964d3846 (presubmit successful).

4 years, 11 months ago (2016-01-12 01:46:26 UTC) #4

skybrian

4 years, 11 months ago (2016-01-12 01:49:54 UTC) #5

Message was sent while issue was closed.

On 2016/01/12 01:46:26, scheglov wrote:
> Committed patchset #1 (id:1) manually as
> 925458da82763fe0fef55a525a02b5dc964d3846 (presubmit successful).

--x-perf-report should pick this up automatically (and any other PerformanceTags
we add).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages