third_party/WebKit/Source/core/frame/PageScaleConstraintsSet.h - Issue 1573283002: Don't change layout size due to top control show/hide

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/frame/PageScaleConstraintsSet.h

Issue 1573283002: Don't change layout size due to top control show/hide (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove redundant call to viewportSizeForViewportUnits Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/frame/FrameView.cpp ('k') | third_party/WebKit/Source/core/frame/PageScaleConstraintsSet.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/frame/PageScaleConstraintsSet.h

diff --git a/third_party/WebKit/Source/core/frame/PageScaleConstraintsSet.h b/third_party/WebKit/Source/core/frame/PageScaleConstraintsSet.h

index 0dabd0f8a07769d640c6fc3715f070c0f1048347..7104d6daa23c45c9125d662b71d2cba831619383 100644

--- a/third_party/WebKit/Source/core/frame/PageScaleConstraintsSet.h

+++ b/third_party/WebKit/Source/core/frame/PageScaleConstraintsSet.h

@@ -85,9 +85,7 @@ public:

// This is set when one of the inputs to finalConstraints changes.

bool constraintsDirty() const { return m_constraintsDirty; }

- void didChangeViewSize(const IntSize&);

- IntSize mainFrameSize() const;

+ void didChangeInitialContainingBlockSize(const IntSize&);

IntSize layoutSize() const;

@@ -103,7 +101,7 @@ private:

PageScaleConstraints m_finalConstraints;

int m_lastContentsWidth;

- IntSize m_viewSize;

+ IntSize m_icbSize;

bool m_needsReset;

bool m_constraintsDirty;