third_party/WebKit/Source/core/css/CSSToLengthConversionData.cpp - Issue 1573283002: Don't change layout size due to top control show/hide

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/CSSToLengthConversionData.cpp

Issue 1573283002: Don't change layout size due to top control show/hide (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: jbroman@ review Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/css/CSSToLengthConversionData.h ('k') | third_party/WebKit/Source/core/css/resolver/ViewportStyleResolver.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/css/CSSToLengthConversionData.cpp

diff --git a/third_party/WebKit/Source/core/css/CSSToLengthConversionData.cpp b/third_party/WebKit/Source/core/css/CSSToLengthConversionData.cpp

index a3c732e76462eca123abe0a46af7f6eb91b38f68..72b2dbd4e1c353a865d82704f801b8fce633fbef 100644

--- a/third_party/WebKit/Source/core/css/CSSToLengthConversionData.cpp

+++ b/third_party/WebKit/Source/core/css/CSSToLengthConversionData.cpp

@@ -68,8 +68,9 @@ float CSSToLengthConversionData::FontSizes::ch() const

}

CSSToLengthConversionData::ViewportSize::ViewportSize(const LayoutView* layoutView)

- : m_width(layoutView ? layoutView->layoutViewportWidth() : 0)

- , m_height(layoutView ? layoutView->layoutViewportHeight() : 0)

+ : m_size(

jbroman 2016/01/20 16:50:25 DoubleSize can be constructed from the FloatSize,

bokan 2016/01/20 16:51:21 Ack, you're right. I'll up a new patch.

+ layoutView ? layoutView->viewportSizeForViewportUnits().width() : 0,

+ layoutView ? layoutView->viewportSizeForViewportUnits().height() : 0)

{

}