third_party/WebKit/Source/core/layout/LayoutView.cpp - Issue 1573283002: Don't change layout size due to top control show/hide

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutView.cpp

Issue 1573283002: Don't change layout size due to top control show/hide (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/frame/FrameView.cpp ('K') | « third_party/WebKit/Source/core/layout/LayoutView.h ('k') | third_party/WebKit/Source/web/WebViewImpl.cpp » ('j') | third_party/WebKit/Source/web/WebViewImpl.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/LayoutView.cpp

diff --git a/third_party/WebKit/Source/core/layout/LayoutView.cpp b/third_party/WebKit/Source/core/layout/LayoutView.cpp

index b84eba735d75a2a6988cb780a05e42b83bef8dd4..c4b1ab4b43979500ab67df76d3b70c6c1ef047f3 100644

--- a/third_party/WebKit/Source/core/layout/LayoutView.cpp

+++ b/third_party/WebKit/Source/core/layout/LayoutView.cpp

@@ -962,16 +962,9 @@ bool LayoutView::backgroundIsKnownToBeOpaqueInRect(const LayoutRect&) const

return m_frameView->hasOpaqueBackground();

}

-double LayoutView::layoutViewportWidth() const

+FloatSize LayoutView::viewportSizeForViewportUnits() const

{

- float scale = m_frameView ? m_frameView->frame().pageZoomFactor() : 1;

- return viewWidth(IncludeScrollbars) / scale;

-double LayoutView::layoutViewportHeight() const

- float scale = m_frameView ? m_frameView->frame().pageZoomFactor() : 1;

- return viewHeight(IncludeScrollbars) / scale;

+ return frameView()->viewportSizeForViewportUnits();

}

void LayoutView::willBeDestroyed()