Don't change layout size due to top control show/hide

third_party/WebKit/Source/web/WebViewImpl.cpp

 /*
  * Copyright (C) 2011, 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 1819 matching lines @@
 }
 
 void WebViewImpl::resizeVisualViewport(const WebSize& newSize)
 {
     page()->frameHost().visualViewport().setSize(newSize);
     page()->frameHost().visualViewport().clampToBoundaries();
 }
 
 void WebViewImpl::performResize()
 {
-    pageScaleConstraintsSet().didChangeViewSize(m_size);
+    // We'll keep the initial containing block size from changing when the top
+    // controls hide so that the ICB will always be the same size as the
+    // viewport with the top controls shown.
+    IntSize ICBSize = m_size;
+    if (!topControls().shrinkViewport())

[aelias_OOO_until_Jul13, 2016/01/16 04:17:38]

TopControls::layoutHeight() already includes this branch.

[bokan, 2016/01/19 00:05:31]

It's actually the converse. When the top controls are hidden layoutHeight() will
be 0 but in this case we want to subtract their height from the WebView size to
keep the ICB from changing size.

+        ICBSize.expand(0, -topControls().height());
+
+    pageScaleConstraintsSet().didChangeInitialContainingBlockSize(ICBSize);
 
     updatePageDefinedViewportConstraints(mainFrameImpl()->frame()->document()->viewportDescription());
     updateMainFrameLayoutSize();
 
     page()->frameHost().visualViewport().setSize(m_size);
 
     if (mainFrameImpl()->frameView()) {
         if (!mainFrameImpl()->frameView()->needsLayout())
             postLayoutResize(mainFrameImpl());
     }
@@ skipping 60 matching lines @@
 {
     if (m_shouldAutoResize || m_size == newSize)
         return;
 
     if (page()->mainFrame() && !page()->mainFrame()->isLocalFrame()) {
         // Viewport resize for a remote main frame does not require any
         // particular action, but the state needs to reflect the correct size
         // so that it can be used for initalization if the main frame gets
         // swapped to a LocalFrame at a later time.
         m_size = newSize;
-        pageScaleConstraintsSet().didChangeViewSize(m_size);
+        pageScaleConstraintsSet().didChangeInitialContainingBlockSize(m_size);
         page()->frameHost().visualViewport().setSize(m_size);
         return;
     }
 
     WebLocalFrameImpl* mainFrame = mainFrameImpl();
     if (!mainFrame)
         return;
 
     FrameView* view = mainFrame->frameView();
     if (!view)
@@ skipping 1355 matching lines @@
         constraints.maximumScale = pageScaleConstraintsSet().defaultConstraints().maximumScale;
     } else {
         constraints.minimumScale = -1;
         constraints.maximumScale = -1;
     }
     page()->frameHost().setUserAgentPageScaleConstraints(constraints);
 }
 
 IntSize WebViewImpl::mainFrameSize()
 {
-    return pageScaleConstraintsSet().mainFrameSize();
+    // The frame size should match the viewport size at minimum scale, since the
+    // viewport must always be contained by the frame.
+    FloatSize frameSize(m_size);
+    frameSize.scale(1 / minimumPageScaleFactor());
+    return expandedIntSize(frameSize);
 }
 
 PageScaleConstraintsSet& WebViewImpl::pageScaleConstraintsSet() const
 {
     return page()->frameHost().pageScaleConstraintsSet();
 }
 
 void WebViewImpl::refreshPageScaleFactorAfterLayout()
 {
     if (!mainFrame() || !page() || !page()->mainFrame() || !page()->mainFrame()->isLocalFrame() || !page()->deprecatedLocalMainFrame()->view())
         return;
     FrameView* view = page()->deprecatedLocalMainFrame()->view();
+    Document* document = mainFrameImpl()->frame()->document();
 
-    updatePageDefinedViewportConstraints(mainFrameImpl()->frame()->document()->viewportDescription());
+    float oldMinimumPSF = minimumPageScaleFactor();
+
+    updatePageDefinedViewportConstraints(document->viewportDescription());
     pageScaleConstraintsSet().computeFinalConstraints();
 
+    // If the minimum page scale factor changed, the amount we add to the layout
+    // size due to top controls for viewport units will also have changed. i.e.
+    // For 100vh we need to add the top controls to the layout size but the
+    // top controls height is scaled so that at minimum scale, 100vh covers
+    // exactly the viewport height with top controls hidden.
+    if (topControls().height() && oldMinimumPSF != minimumPageScaleFactor()) {
+        if (document->isActive())
+            document->notifyResizeForViewportUnits();

[aelias_OOO_until_Jul13, 2016/01/16 04:17:38]

Likewise a test that fails if this isn't called.

[bokan, 2016/01/19 00:05:31]

This is no longer needed now that I use the layout width scale rather than
minimum scale.

+    }
+
     int verticalScrollbarWidth = 0;
     if (view->verticalScrollbar() && !view->verticalScrollbar()->isOverlayScrollbar())
         verticalScrollbarWidth = view->verticalScrollbar()->width();
     pageScaleConstraintsSet().adjustFinalConstraintsToContentsSize(contentsSize(), verticalScrollbarWidth, settings()->shrinksViewportContentToFit());
 
     float newPageScaleFactor = pageScaleFactor();
     if (pageScaleConstraintsSet().needsReset() && pageScaleConstraintsSet().finalConstraints().initialScale != -1) {
         newPageScaleFactor = pageScaleConstraintsSet().finalConstraints().initialScale;
         pageScaleConstraintsSet().setNeedsReset(false);
     }
@@ skipping 766 matching lines @@
     LocalFrame* frame = webframe->frame();
     if (!m_client || !frame->isLocalRoot())
         return;
 
     if (m_shouldAutoResize) {
         WebSize frameSize = frame->view()->frameRect().size();
         if (frameSize != m_size) {
             m_size = frameSize;
 
             page()->frameHost().visualViewport().setSize(m_size);
-            pageScaleConstraintsSet().didChangeViewSize(m_size);
+            pageScaleConstraintsSet().didChangeInitialContainingBlockSize(m_size);
 
             m_client->didAutoResize(m_size);
             sendResizeEventAndRepaint();
         }
     }
 
     if (pageScaleConstraintsSet().constraintsDirty())
         refreshPageScaleFactorAfterLayout();
 
     FrameView* view = webframe->frame()->view();
@@ skipping 511 matching lines @@
 {
     // TODO(oshima): Investigate if this should return the ScreenInfo's scale factor rather than
     // page's scale factor, which can be 1 in use-zoom-for-dsf mode.
     if (!page())
         return 1;
 
     return page()->deviceScaleFactor();
 }
 
 } // namespace blink