Issue 1573243016: Revert "Cleanup CJS_PublicMethods::ParseNumber"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1573243016: Revert "Cleanup CJS_PublicMethods::ParseNumber" (Closed)

Created:
4 years, 11 months ago by Tom Sepez

Modified:
4 years, 11 months ago

Reviewers:
Lei Zhang, Tom Bergan

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Revert "Cleanup CJS_PublicMethods::ParseNumber" This reverts commit 4cd5b80e70e5fc50d8bd805cfa3c7b54878a0a35. Reason for revert: broke tests on windows TBR=tombergan@chromium.org TBR=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/283ef3c9292889ef7d53e9e451f9272d4efb0221

Created: 4 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+172 lines, -44 lines)			Patch
M	fpdfsdk/src/javascript/Field.cpp	View	3 chunks	+17 lines, -5 lines	0 comments	Download
M	fpdfsdk/src/javascript/PublicMethods.h	View	1 chunk	+8 lines, -1 line	0 comments	Download
M	fpdfsdk/src/javascript/PublicMethods.cpp	View	1 chunk	+131 lines, -22 lines	0 comments	Download
M	testing/resources/javascript/bug_361_expected.txt	View	1 chunk	+16 lines, -16 lines	0 comments	Download

Total messages: 3 (1 generated)

Tom Sepez

4 years, 11 months ago (2016-01-15 01:35:08 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
283ef3c9292889ef7d53e9e451f9272d4efb0221 (tree was closed).