Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1881)

Unified Diff: net/cert/internal/verify_certificate_chain_unittest.cc

Issue 1573243011: Refactor der::Input helper methods into new constructors (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix nits Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/cert/internal/verify_certificate_chain.cc ('k') | net/cert/internal/verify_signed_data_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/cert/internal/verify_certificate_chain_unittest.cc
diff --git a/net/cert/internal/verify_certificate_chain_unittest.cc b/net/cert/internal/verify_certificate_chain_unittest.cc
index 0b178e9069aa1b1be8ec41e68844377fb3518a26..c997f5386ef87cb3d04df5d0089a622a67e60351 100644
--- a/net/cert/internal/verify_certificate_chain_unittest.cc
+++ b/net/cert/internal/verify_certificate_chain_unittest.cc
@@ -47,7 +47,7 @@ std::string ReadTestFileToString(const std::string& file_name) {
void AddCertificateToTrustStore(const std::string& cert_der,
TrustStore* trust_store) {
ParsedCertificate cert;
- ASSERT_TRUE(ParseCertificate(InputFromString(&cert_der), &cert));
+ ASSERT_TRUE(ParseCertificate(der::Input(&cert_der), &cert));
ParsedTbsCertificate tbs;
ASSERT_TRUE(ParseTbsCertificate(cert.tbs_certificate_tlv, &tbs));
@@ -95,7 +95,7 @@ void ReadTestFromFile(const std::string& file_name,
} else if (block_type == kTimeHeader) {
ASSERT_FALSE(has_time) << "Duplicate " << kTimeHeader;
has_time = true;
- ASSERT_TRUE(der::ParseUTCTime(InputFromString(&block_data), time));
+ ASSERT_TRUE(der::ParseUTCTime(der::Input(&block_data), time));
} else if (block_type == kResultHeader) {
ASSERT_FALSE(has_result) << "Duplicate " << kResultHeader;
ASSERT_TRUE(block_data == "SUCCESS" || block_data == "FAIL")
@@ -119,7 +119,7 @@ void RunTest(const char* file_name) {
std::vector<der::Input> input_chain;
for (const auto& cert_str : chain)
- input_chain.push_back(InputFromString(&cert_str));
+ input_chain.push_back(der::Input(&cert_str));
SimpleSignaturePolicy signature_policy(1024);
« no previous file with comments | « net/cert/internal/verify_certificate_chain.cc ('k') | net/cert/internal/verify_signed_data_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698