Refactor der::Input helper methods into new constructors

net/cert/internal/test_helpers.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_CERT_INTERNAL_TEST_HELPERS_H_
 #define NET_CERT_INTERNAL_TEST_HELPERS_H_
 
 #include <stddef.h>
 
 #include <ostream>
 #include <string>
 #include <vector>
 
 #include "net/der/input.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace net {
 
 namespace der {
 
 // These functions are used by GTest to support EXPECT_EQ() for
 // der::Input.
 void PrintTo(const Input& data, ::std::ostream* os);
 bool operator==(const Input& a, const Input& b);
 
 }  // namespace der
 
-// Creates a der::Input from an std::string. The lifetimes are a bit subtle
-// when using this function:
-//
-// The returned der::Input() is only valid so long as the input string is alive
-// and is not mutated.
-//
-// Note that the input parameter has been made a pointer to prevent callers
-// from accidentally passing an r-value.
-der::Input InputFromString(const std::string* s);
-
 // Parses |s| as a DER SEQUENCE TLV and returns a der::Input corresponding to
 // the value portion. On error returns an empty der::Input and adds a gtest
 // failure.
 //
 // The returned der::Input() is only valid so long as the input string is alive
 // and is not mutated.
 der::Input SequenceValueFromString(const std::string* s);
 
 // Helper structure that maps a PEM block header (for instance "CERTIFICATE") to
 // the destination where the value for that block should be written.
@@ skipping 34 matching lines @@
 template <size_t N>
 ::testing::AssertionResult ReadTestDataFromPemFile(
     const std::string& file_path_ascii,
     const PemBlockMapping(&mappings)[N]) {
   return ReadTestDataFromPemFile(file_path_ascii, mappings, N);
 }
 
 }  // namespace net
 
 #endif  // NET_CERT_INTERNAL_TEST_HELPERS_H_