[builtins] Migrate Number constructor similar to String constructor.

[builtins] Migrate Number constructor similar to String constructor.

Also migrate the Number constructor to a native builtin, using the
same mechanism already used by the String constructor. Otherwise just
parsing and compiling the Number constructor to optimized code already
eats 2ms on desktop for no good reason, and the resulting optimized
code is not even close to awesome.

Drive-by-fix: Use correct context for the [[Construct]] case of the
String constructor as well, and share some code with it.

R=jarin@chromium.org

Committed: https://crrev.com/322ffda30dfefd7101a2bd93e33563cf19fbb022
Cr-Commit-Position: refs/heads/master@{#33265}

[Benedikt Meurer, 2016-01-13 11:33:30]

bmeurer@chromium.org changed reviewers:
+ verwaest@chromium.org

[Benedikt Meurer, 2016-01-13 11:33:30]

Jaro: PTAL
Toon: FYI, as discussed offline

[Jarin, 2016-01-13 12:05:18]

jarin@chromium.org changed reviewers:
+ mstarzinger@chromium.org

[Jarin, 2016-01-13 12:05:18]

jarin@chromium.org changed required reviewers:
+ mstarzinger@chromium.org

[Jarin, 2016-01-13 12:05:19]

the code lgtm, but it surely is quite a lot of native code. Adding Michi, who
might have a stronger opinion on this.

https://codereview.chromium.org/1573243009/diff/1/src/x64/builtins-x64.cc
File src/x64/builtins-x64.cc (right):

https://codereview.chromium.org/1573243009/diff/1/src/x64/builtins-x64.cc#new...
src/x64/builtins-x64.cc:1473: // 2b. No arguments, return +0 (already in rax).
Hmm, I see it's already micro-optimized...

[Michael Starzinger, 2016-01-13 13:50:32]

LGTM.

As discussed offline: I am still not a huge fan of the amount of hand-written
assembly everywhere. It sure would be nice to have some sort of
architecture-independent assembler for these stubs (wink, CodeStubAssembler,
wink) at some point. But my opinion is not strong enough to block this CL for
it.

[Benedikt Meurer, 2016-01-13 14:10:18]

The CQ bit was checked by bmeurer@chromium.org

[commit-bot: I haz the power, 2016-01-13 14:10:29]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1573243009/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1573243009/1

[commit-bot: I haz the power, 2016-01-13 15:14:21]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-01-13 15:15:18]

Description was changed from

==========
[builtins] Migrate Number constructor similar to String constructor.

Also migrate the Number constructor to a native builtin, using the
same mechanism already used by the String constructor. Otherwise just
parsing and compiling the Number constructor to optimized code already
eats 2ms on desktop for no good reason, and the resulting optimized
code is not even close to awesome.

Drive-by-fix: Use correct context for the [[Construct]] case of the
String constructor as well, and share some code with it.

R=jarin@chromium.org
==========

to

==========
[builtins] Migrate Number constructor similar to String constructor.

Also migrate the Number constructor to a native builtin, using the
same mechanism already used by the String constructor. Otherwise just
parsing and compiling the Number constructor to optimized code already
eats 2ms on desktop for no good reason, and the resulting optimized
code is not even close to awesome.

Drive-by-fix: Use correct context for the [[Construct]] case of the
String constructor as well, and share some code with it.

R=jarin@chromium.org

Committed: https://crrev.com/322ffda30dfefd7101a2bd93e33563cf19fbb022
Cr-Commit-Position: refs/heads/master@{#33265}
==========

[commit-bot: I haz the power, 2016-01-13 15:15:19]

Patchset 1 (id:??) landed as
https://crrev.com/322ffda30dfefd7101a2bd93e33563cf19fbb022
Cr-Commit-Position: refs/heads/master@{#33265}