Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 1573213002: [wasm] Create a wrapper function for WASM.asmCompileRun(). (Closed)

Created:
4 years, 11 months ago by titzer
Modified:
4 years, 11 months ago
Reviewers:
bradnelson, ahaas
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Create a wrapper function for WASM.asmCompileRun(). R=bradnelson@chromium.org, ahaas@chromium.org LOG=Y BUG=chromium:575372 Committed: https://crrev.com/b577ecfd6a86059b5a82f807e15276b5e193b229 Cr-Commit-Position: refs/heads/master@{#33366}

Patch Set 1 #

Patch Set 2 : Rebase on fixes for preaging #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : Disable arm64 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -24 lines) Patch
M src/wasm/wasm-module.cc View 1 2 2 chunks +35 lines, -24 lines 0 comments Download
M test/cctest/wasm/test-run-wasm-module.cc View 1 2 3 4 4 chunks +9 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
titzer
4 years, 11 months ago (2016-01-11 17:39:22 UTC) #1
bradnelson
lgtm I assume this was prompted by some of the clusterfuzz failures?
4 years, 11 months ago (2016-01-12 00:39:42 UTC) #2
titzer
On 2016/01/12 00:39:42, bradnelson wrote: > lgtm > > I assume this was prompted by ...
4 years, 11 months ago (2016-01-18 14:40:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1573213002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1573213002/80001
4 years, 11 months ago (2016-01-18 15:37:42 UTC) #6
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 11 months ago (2016-01-18 15:39:09 UTC) #7
commit-bot: I haz the power
4 years, 11 months ago (2016-01-18 15:39:55 UTC) #9
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/b577ecfd6a86059b5a82f807e15276b5e193b229
Cr-Commit-Position: refs/heads/master@{#33366}

Powered by Google App Engine
This is Rietveld 408576698