Issue 1573203003: Compute public namespace during resynthesizing.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1573203003: Compute public namespace during resynthesizing. (Closed)

Created:
4 years, 11 months ago by scheglov

Modified:
4 years, 11 months ago

Reviewers:
Paul Berry

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Compute public namespace during resynthesizing. R=paulberry@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/11d1147df8d61992b05bc06a6121bd1b70d3f3ae

Patch Set 1 #

Total comments: 1

Created: 4 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -2 lines)			Patch
	M	pkg/analyzer/lib/src/summary/resynthesize.dart	View		1 chunk	+4 lines, -0 lines	0 comments	Download
	M	pkg/analyzer/test/src/summary/resynthesize_test.dart	View		3 chunks	+16 lines, -2 lines	1 comment	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Paul Berry

lgtm with one minor nit https://codereview.chromium.org/1573203003/diff/1/pkg/analyzer/test/src/summary/resynthesize_test.dart File pkg/analyzer/test/src/summary/resynthesize_test.dart (right): https://codereview.chromium.org/1573203003/diff/1/pkg/analyzer/test/src/summary/resynthesize_test.dart#newcode325 pkg/analyzer/test/src/summary/resynthesize_test.dart:325: expect(resynthesizedMap.keys, originalMap.keys, reason: desc); ...

4 years, 11 months ago (2016-01-11 22:27:25 UTC) #2

scheglov

4 years, 11 months ago (2016-01-11 23:05:44 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
11d1147df8d61992b05bc06a6121bd1b70d3f3ae (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages