third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.idl - Issue 1573173002: Make WebGL's texImage2D and texSubImage2D handle cross-origin ImageBitmap

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.idl

Issue 1573173002: Make WebGL's texImage2D and texSubImage2D handle cross-origin ImageBitmap (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add validateImageBitmap helper function & a layout test Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/http/tests/security/webgl-cross-origin-ImageBitmap-blocked.html ('K') | « third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.idl

diff --git a/third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.idl b/third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.idl

index 16f62a8cbd1e5091744ff9a4cdbdc31111621fec..ed15f28f3bf4327f1f77ac61b73cc246e9ddbca7 100644

--- a/third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.idl

+++ b/third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.idl

@@ -631,7 +631,7 @@ typedef unrestricted float GLclampf;

[RaisesException] void texImage2D(

GLenum target, GLint level, GLint internalformat,

GLenum format, GLenum type, HTMLVideoElement video);

- [RuntimeEnabled=ExperimentalCanvasFeatures] void texImage2D(

+ [RaisesException, RuntimeEnabled=ExperimentalCanvasFeatures] void texImage2D(

GLenum target, GLint level, GLint internalformat,

GLenum format, GLenum type, ImageBitmap bitmap);

@@ -651,7 +651,7 @@ typedef unrestricted float GLclampf;

[RaisesException] void texSubImage2D(

GLenum target, GLint level, GLint xoffset, GLint yoffset,

GLenum format, GLenum type, HTMLVideoElement video);

- [RuntimeEnabled=ExperimentalCanvasFeatures] void texSubImage2D(

+ [RaisesException, RuntimeEnabled=ExperimentalCanvasFeatures] void texSubImage2D(

GLenum target, GLint level, GLint xoffset, GLint yoffset,

GLenum format, GLenum type, ImageBitmap bitmap);