third_party/WebKit/LayoutTests/http/tests/security/webgl-cross-origin-ImageBitmap-blocked.html - Issue 1573173002: Make WebGL's texImage2D and texSubImage2D handle cross-origin ImageBitmap

Side by Side Diff: third_party/WebKit/LayoutTests/http/tests/security/webgl-cross-origin-ImageBitmap-blocked.html

Issue 1573173002: Make WebGL's texImage2D and texSubImage2D handle cross-origin ImageBitmap (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: layout tests includes both origin-clean and tainted-origin imagebitmap Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <html>

	3 <body>

	4 <script src="/js-test-resources/js-test.js"></script>

	5 <script>

	6 description("WebGL's tex(Sub)Image2D should throw a SecurityError exception when the ImageBitmap is not origin clean.");

	7

	8 window.jsTestIsAsync = true;

	9 var gl;

	10 var bitmap;

	11

	12 var image = document.createElement('img');

	13 image.src = 'http://localhost:8080/security/resources/abe.png';

	14

	15 image.addEventListener('load', function() {

	16 var canvas = document.createElement("canvas");

	17 canvas.width = 10;

	18 canvas.height = 10;

	19

	20 // ImageBitmap created from a clean canvas should be origin clean

	21 createImageBitmap(canvas, 0, 0, 10, 10).then(imageBitmap => {

	22 bitmap = imageBitmap;

	23 shouldNotThrow("gl.texImage2D(gl.TEXTURE_2D, 0, gl.RGBA, gl.RGBA, gl.UNS IGNED_BYTE, bitmap)");
	Ken Russell (switch to Gerrit) 2016/01/12 05:03:22 Follow this up with shouldBe("gl.getError()", "gl. Follow this up with shouldBe("gl.getError()", "gl.NO_ERROR"). xidachen 2016/01/12 13:58:37 Acknowledged. Show quoted text On 2016/01/12 05:03:22, Ken Russell wrote: > Follow this up with shouldBe("gl.getError()", "gl.NO_ERROR"). Acknowledged.
	24 shouldNotThrow("gl.texSubImage2D(gl.TEXTURE_2D, 0, 0, 0, gl.RGBA, gl.UNS IGNED_BYTE, bitmap)");
	Ken Russell (switch to Gerrit) 2016/01/12 05:03:22 Same here. Same here. xidachen 2016/01/12 13:58:37 Acknowledged. Show quoted text On 2016/01/12 05:03:22, Ken Russell wrote: > Same here. Acknowledged.
	25 }, () => {

	26 testFailed("Unexpected failure");

	27 finishJSTest();

	28 });

	29

	30 // Testing tainted ImageBitmap

	31 gl = canvas.getContext("webgl");
	Ken Russell (switch to Gerrit) 2016/01/12 05:03:22 You should create a texture object and bind it to You should create a texture object and bind it to the TEXTURE_2D binding point. Otherwise all of the GL calls can fail for other reasons, and you want to make sure that only one possible failure can happen because of the tainted ImageBitmap. var texture = gl.createTexture(); gl.bindTexture(gl.TEXTURE_2D, texture); xidachen 2016/01/12 13:58:37 Acknowledged. Show quoted text On 2016/01/12 05:03:22, Ken Russell wrote: > You should create a texture object and bind it to the TEXTURE_2D binding point. > Otherwise all of the GL calls can fail for other reasons, and you want to make > sure that only one possible failure can happen because of the tainted > ImageBitmap. > > var texture = gl.createTexture(); > gl.bindTexture(gl.TEXTURE_2D, texture); Acknowledged.
	32 createImageBitmap(image, 0, 0, 10, 10).then(imageBitmap => {

	33 bitmap = imageBitmap;

	34 shouldThrow("gl.texImage2D(gl.TEXTURE_2D, 0, gl.RGBA, gl.RGBA, gl.UNSIGN ED_BYTE, bitmap)");
	Ken Russell (switch to Gerrit) 2016/01/12 05:03:22 Follow this up with shouldBe("gl.getError()", "gl. Follow this up with shouldBe("gl.getError()", "gl.NO_ERROR"). xidachen 2016/01/12 13:58:37 Acknowledged. Show quoted text On 2016/01/12 05:03:22, Ken Russell wrote: > Follow this up with shouldBe("gl.getError()", "gl.NO_ERROR"). Acknowledged.
	35 shouldThrow("gl.texSubImage2D(gl.TEXTURE_2D, 0, 0, 0, gl.RGBA, gl.UNSIGN ED_BYTE, bitmap)");
	Ken Russell (switch to Gerrit) 2016/01/12 05:03:22 Same here. Same here. xidachen 2016/01/12 13:58:37 Acknowledged. Show quoted text On 2016/01/12 05:03:22, Ken Russell wrote: > Same here. Acknowledged.
	36 finishJSTest();

	37 }, () => {

	38 testFailed("Unexpected failure");

	39 finishJSTest();

	40 });
	Ken Russell (switch to Gerrit) 2016/01/12 05:03:22 Shouldn't this entire second createImageBitmap cal Shouldn't this entire second createImageBitmap call and its promise callbacks go inside the success callback of the first promise (after the second "shouldNotThrow" for texSubImage2D)? Otherwise the promises may resolve in an arbitrary order, leading to flakiness of the layout test. xidachen 2016/01/12 13:58:37 Acknowledged. Show quoted text On 2016/01/12 05:03:22, Ken Russell wrote: > Shouldn't this entire second createImageBitmap call and its promise callbacks go > inside the success callback of the first promise (after the second > "shouldNotThrow" for texSubImage2D)? Otherwise the promises may resolve in an > arbitrary order, leading to flakiness of the layout test. Acknowledged.
	41 });

	42 </script>

	43 </body>

	44 </html>

OLD	NEW