Add flag to make await and yield keywords

Add flag to make await and yield keywords

Using --await_is_kw forces the parser to treat await and yield as keywords even in synchronous code.

BUG=
R=iposva@google.com, zra@google.com

Committed: https://github.com/dart-lang/sdk/commit/0964f26d24e30843ec7121073fb1012785a50ba4

[hausner, 2016-01-11 23:26:09]

Description was changed from

==========
Add flag to make await and yield keywords

BUG=
==========

to

==========
Add flag to make await and yield keywords

Using --await_is_kw forces the parser to treat await and yield as keywords even
in synchronous code.

BUG=
==========

[hausner, 2016-01-11 23:26:09]

hausner@google.com changed reviewers:
+ zra@google.com

[zra, 2016-01-12 05:29:39]

lgtm

https://codereview.chromium.org/1573153003/diff/1/runtime/vm/parser.cc
File runtime/vm/parser.cc (right):

https://codereview.chromium.org/1573153003/diff/1/runtime/vm/parser.cc#newcode55
runtime/vm/parser.cc:55: DEFINE_FLAG(bool, await_is_kw, false,
I'll have to hardcode this flag into the Mojo source, and spelling out 'keyword'
will probably make it more readable there.

[Ivan Posva, 2016-01-12 06:14:31]

iposva@google.com changed reviewers:
+ iposva@google.com

[Ivan Posva, 2016-01-12 06:14:32]

Whitespace nit, otherwise LGTM.

-Ivan

https://codereview.chromium.org/1573153003/diff/1/runtime/vm/parser.cc
File runtime/vm/parser.cc (right):

https://codereview.chromium.org/1573153003/diff/1/runtime/vm/parser.cc#newcod...
runtime/vm/parser.cc:10190: return (FLAG_await_is_kw ||await_is_keyword_) &&
IsSymbol(Symbols::YieldKw());
Missing space.

[hausner, 2016-01-12 17:49:51]

https://codereview.chromium.org/1573153003/diff/1/runtime/vm/parser.cc
File runtime/vm/parser.cc (right):

https://codereview.chromium.org/1573153003/diff/1/runtime/vm/parser.cc#newcode55
runtime/vm/parser.cc:55: DEFINE_FLAG(bool, await_is_kw, false,
On 2016/01/12 05:29:39, zra wrote:
> I'll have to hardcode this flag into the Mojo source, and spelling out
'keyword'
> will probably make it more readable there.

Done that for you, even though I had to break up the expressions over two lines
as a result :)

https://codereview.chromium.org/1573153003/diff/1/runtime/vm/parser.cc#newcod...
runtime/vm/parser.cc:10190: return (FLAG_await_is_kw ||await_is_keyword_) &&
IsSymbol(Symbols::YieldKw());
On 2016/01/12 06:14:32, Ivan Posva wrote:
> Missing space.

Done.

[hausner, 2016-01-12 17:52:53]

Description was changed from

==========
Add flag to make await and yield keywords

Using --await_is_kw forces the parser to treat await and yield as keywords even
in synchronous code.

BUG=
==========

to

==========
Add flag to make await and yield keywords

Using --await_is_kw forces the parser to treat await and yield as keywords even
in synchronous code.

BUG=
R=iposva@google.com, zra@google.com

Committed:
https://github.com/dart-lang/sdk/commit/0964f26d24e30843ec7121073fb1012785a50ba4
==========

[hausner, 2016-01-12 17:52:55]

Committed patchset #3 (id:40001) manually as
0964f26d24e30843ec7121073fb1012785a50ba4 (presubmit successful).

[zra, 2016-01-12 17:54:22]

https://codereview.chromium.org/1573153003/diff/1/runtime/vm/parser.cc
File runtime/vm/parser.cc (right):

https://codereview.chromium.org/1573153003/diff/1/runtime/vm/parser.cc#newcode55
runtime/vm/parser.cc:55: DEFINE_FLAG(bool, await_is_kw, false,
On 2016/01/12 17:49:51, hausner wrote:
> On 2016/01/12 05:29:39, zra wrote:
> > I'll have to hardcode this flag into the Mojo source, and spelling out
> 'keyword'
> > will probably make it more readable there.
> 
> Done that for you, even though I had to break up the expressions over two
lines
> as a result :)

Thanks =)