Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Issue 1573153002: [turbofan] Use inline allocation for closures. (Closed)

Created:
4 years, 11 months ago by Michael Starzinger
Modified:
4 years, 8 months ago
Reviewers:
mvstanton
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Use inline allocation for closures. This changes closure creation to lower to inline allocations when possible instead of going through the FastNewClosureStub. It allows us to leverage all advantages of inline allocations on closures. Note that it is only safe to embed the raw entry point of the compile lazy stub into the code, because that stub is immortal and immovable. R=mvstanton@chromium.org Committed: https://crrev.com/43c7c76f1de26786884624df5435c766f4fe2fbe Cr-Commit-Position: refs/heads/master@{#35499}

Patch Set 1 #

Patch Set 2 : Drop stub case and adapt unit test. #

Patch Set 3 : Rebased. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+109 lines, -0 lines) Patch
M src/compiler/access-builder.h View 1 chunk +12 lines, -0 lines 0 comments Download
M src/compiler/access-builder.cc View 1 2 2 chunks +31 lines, -0 lines 0 comments Download
M src/compiler/js-create-lowering.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/js-create-lowering.cc View 1 2 2 chunks +47 lines, -0 lines 0 comments Download
M test/unittests/compiler/js-create-lowering-unittest.cc View 1 2 1 chunk +18 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Michael Starzinger
Just a first prototype. Not planning to land any of this before we switched the ...
4 years, 11 months ago (2016-01-11 15:37:17 UTC) #1
Michael Starzinger
This has just been upgraded from prototype to product. PTAL. :)
4 years, 8 months ago (2016-04-13 12:33:10 UTC) #2
mvstanton
lgtm
4 years, 8 months ago (2016-04-14 12:41:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1573153002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1573153002/40001
4 years, 8 months ago (2016-04-14 14:56:04 UTC) #5
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 8 months ago (2016-04-14 15:17:36 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-14 15:19:26 UTC) #8
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/43c7c76f1de26786884624df5435c766f4fe2fbe
Cr-Commit-Position: refs/heads/master@{#35499}

Powered by Google App Engine
This is Rietveld 408576698