src/messages.h - Issue 1573143002: Do not leak private property names to proxy traps and interceptors.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/messages.h

Issue 1573143002: Do not leak private property names to proxy traps and interceptors. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Address comments Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/messages.h

diff --git a/src/messages.h b/src/messages.h

index 1f55412bce5877da362a9f37964f13189fc6ccb2..56ee037ab4963829e1176ff4cf54e51f8431a758 100644

--- a/src/messages.h

+++ b/src/messages.h

@@ -257,6 +257,7 @@ class CallSite {

T(ProxyPreventExtensionsExtensible, \

"'preventExtensions' on proxy: trap returned truish but the proxy target " \

"is extensible") \

+ T(ProxyPrivate, "Cannot not pass private property name to proxy trap") \

rossberg 2016/01/11 16:01:42 Too many negations, dude.

T(ProxyRevoked, "Cannot perform '%' on a proxy that has been revoked") \

T(ProxySetFrozenData, \

"'set' on proxy: trap returned truish for property '%' which exists in " \

« no previous file with comments | « src/lookup.cc ('k') | src/objects.cc » ('j') | no next file with comments »