Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(336)

Side by Side Diff: test/mjsunit/harmony/private-symbols.js

Issue 1573143002: Do not leak private property names to proxy traps and interceptors. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Typo Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« src/objects.cc ('K') | « src/objects.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
(Empty)
1 // Copyright 2016 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 // Flags: --harmony-proxies --harmony-reflect --allow-natives-syntax
6
7
8 var symbol = %CreatePrivateSymbol("private");
9
10
11 // Private symbols must never be listed.
12
13 var object = {};
14 object[symbol] = 42;
15 for (var key of Object.keys(object)) assertUnreachable();
16 for (var key of Object.getOwnPropertySymbols(object)) assertUnreachable();
17 for (var key of Object.getOwnPropertyNames(object)) assertUnreachable();
18 for (var key of Reflect.ownKeys(object)) assertUnreachable();
19 for (var key of Reflect.enumerate(object)) assertUnreachable();
20 for (var key in object) assertUnreachable();
21
22 var object2 = {__proto__: object};
23 for (var key of Object.keys(object2)) assertUnreachable();
24 for (var key of Object.getOwnPropertySymbols(object2)) assertUnreachable();
25 for (var key of Object.getOwnPropertyNames(object2)) assertUnreachable();
26 for (var key of Reflect.ownKeys(object2)) assertUnreachable();
27 for (var key of Reflect.enumerate(object2)) assertUnreachable();
28 for (var key in object2) assertUnreachable();
29
30
31 // Private symbols must never leak to proxy traps.
32
33 var proxy = new Proxy({}, new Proxy({}, {get() {return () => {throw 666}}}));
34 var object = {__proto__: proxy};
35
36 // [[Set]]
37 assertEquals(42, proxy[symbol] = 42);
38 assertThrows(function() { "use strict"; proxy[symbol] = 42 }, TypeError);
39 assertEquals(false, Reflect.set(proxy, symbol, 42));
40 assertEquals(42, object[symbol] = 42);
41 assertEquals(43, (function() {"use strict"; return object[symbol] = 43})());
42 assertEquals(true, Reflect.set(object, symbol, 44));
43
44 // [[DefineOwnProperty]]
45 assertEquals(false, Reflect.defineProperty(proxy, symbol, {}));
46 assertThrows(() => Object.defineProperty(proxy, symbol, {}), TypeError);
47 assertEquals(true, Reflect.defineProperty(object, symbol, {}));
48 assertEquals(object, Object.defineProperty(object, symbol, {}));
49
50 // [[Delete]]
51 assertEquals(true, delete proxy[symbol]);
52 assertEquals(true, (function() {"use strict"; return delete proxy[symbol]})());
53 assertEquals(true, Reflect.deleteProperty(proxy, symbol));
54 assertEquals(true, delete object[symbol]);
55 assertEquals(true, (function() {"use strict"; return delete object[symbol]})());
56 assertEquals(true, Reflect.deleteProperty(object, symbol));
57
58 // [[GetOwnPropertyDescriptor]]
59 assertEquals(undefined, Object.getOwnPropertyDescriptor(proxy, symbol));
60 assertEquals(undefined, Reflect.getOwnPropertyDescriptor(proxy, symbol));
61 assertFalse(Object.prototype.hasOwnProperty.call(proxy, symbol));
62 assertEquals(undefined, Object.getOwnPropertyDescriptor(object, symbol));
63 assertEquals(undefined, Reflect.getOwnPropertyDescriptor(object, symbol));
64 assertFalse(Object.prototype.hasOwnProperty.call(object, symbol));
65
66 // [[Has]]
67 assertFalse(symbol in proxy);
68 assertFalse(Reflect.has(proxy, symbol));
69 assertFalse(symbol in object);
70 assertFalse(Reflect.has(object, symbol));
71
72 // [[Get]]
73 assertEquals(undefined, proxy[symbol]);
74 assertEquals(undefined, Reflect.get(proxy, symbol));
75 assertEquals(undefined, Reflect.get(proxy, symbol, 42));
76 assertEquals(undefined, object[symbol]);
77 assertEquals(undefined, Reflect.get(object, symbol));
78 assertEquals(undefined, Reflect.get(object, symbol, 42));
OLDNEW
« src/objects.cc ('K') | « src/objects.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698