Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(351)

Side by Side Diff: src/messages.h

Issue 1573143002: Do not leak private property names to proxy traps and interceptors. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Typo Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/lookup.cc ('k') | src/objects.cc » ('j') | src/objects.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2006-2008 the V8 project authors. All rights reserved. 1 // Copyright 2006-2008 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // The infrastructure used for (localized) message reporting in V8. 5 // The infrastructure used for (localized) message reporting in V8.
6 // 6 //
7 // Note: there's a big unresolved issue about ownership of the data 7 // Note: there's a big unresolved issue about ownership of the data
8 // structures used by this framework. 8 // structures used by this framework.
9 9
10 #ifndef V8_MESSAGES_H_ 10 #ifndef V8_MESSAGES_H_
(...skipping 239 matching lines...) Expand 10 before | Expand all | Expand 10 after
250 T(ProxyNonObject, \ 250 T(ProxyNonObject, \
251 "Cannot create proxy with a non-object as target or handler") \ 251 "Cannot create proxy with a non-object as target or handler") \
252 T(ProxyOwnKeysMissing, \ 252 T(ProxyOwnKeysMissing, \
253 "'ownKeys' on proxy: trap result did not include '%'") \ 253 "'ownKeys' on proxy: trap result did not include '%'") \
254 T(ProxyOwnKeysNonExtensible, \ 254 T(ProxyOwnKeysNonExtensible, \
255 "'ownKeys' on proxy: trap returned extra keys but proxy target is " \ 255 "'ownKeys' on proxy: trap returned extra keys but proxy target is " \
256 "non-extensible") \ 256 "non-extensible") \
257 T(ProxyPreventExtensionsExtensible, \ 257 T(ProxyPreventExtensionsExtensible, \
258 "'preventExtensions' on proxy: trap returned truish but the proxy target " \ 258 "'preventExtensions' on proxy: trap returned truish but the proxy target " \
259 "is extensible") \ 259 "is extensible") \
260 T(ProxyPrivate, "Cannot pass private property name to proxy trap") \
260 T(ProxyRevoked, "Cannot perform '%' on a proxy that has been revoked") \ 261 T(ProxyRevoked, "Cannot perform '%' on a proxy that has been revoked") \
261 T(ProxySetFrozenData, \ 262 T(ProxySetFrozenData, \
262 "'set' on proxy: trap returned truish for property '%' which exists in " \ 263 "'set' on proxy: trap returned truish for property '%' which exists in " \
263 "the proxy target as a non-configurable and non-writable data property " \ 264 "the proxy target as a non-configurable and non-writable data property " \
264 "with a different value") \ 265 "with a different value") \
265 T(ProxySetFrozenAccessor, \ 266 T(ProxySetFrozenAccessor, \
266 "'set' on proxy: trap returned truish for property '%' which exists in " \ 267 "'set' on proxy: trap returned truish for property '%' which exists in " \
267 "the proxy target as a non-configurable and non-writable accessor " \ 268 "the proxy target as a non-configurable and non-writable accessor " \
268 "property without a setter") \ 269 "property without a setter") \
269 T(ProxySetPrototypeOfNonExtensible, \ 270 T(ProxySetPrototypeOfNonExtensible, \
(...skipping 277 matching lines...) Expand 10 before | Expand all | Expand 10 after
547 static Handle<String> GetMessage(Isolate* isolate, Handle<Object> data); 548 static Handle<String> GetMessage(Isolate* isolate, Handle<Object> data);
548 static base::SmartArrayPointer<char> GetLocalizedMessage(Isolate* isolate, 549 static base::SmartArrayPointer<char> GetLocalizedMessage(Isolate* isolate,
549 Handle<Object> data); 550 Handle<Object> data);
550 }; 551 };
551 552
552 553
553 } // namespace internal 554 } // namespace internal
554 } // namespace v8 555 } // namespace v8
555 556
556 #endif // V8_MESSAGES_H_ 557 #endif // V8_MESSAGES_H_
OLDNEW
« no previous file with comments | « src/lookup.cc ('k') | src/objects.cc » ('j') | src/objects.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698