Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(390)

Issue 1573123003: Refactor direct_memory_pressure_calculator.h per platform. (Closed)

Created:
4 years, 11 months ago by Georges Khalil
Modified:
4 years, 11 months ago
Reviewers:
chrisha
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Refactor direct_memory_pressure_calculator.h per platform. BUG=520962 Committed: https://crrev.com/a92e2bc86dd9b73f497b05209a3112ae163079fa Cr-Commit-Position: refs/heads/master@{#368691}

Patch Set 1 #

Patch Set 2 : Fix GetSystemMemoryInfo. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -101 lines) Patch
M components/memory_pressure.gypi View 1 1 chunk +1 line, -1 line 0 comments Download
M components/memory_pressure/BUILD.gn View 1 1 chunk +1 line, -1 line 0 comments Download
M components/memory_pressure/direct_memory_pressure_calculator.h View 1 chunk +3 lines, -70 lines 0 comments Download
D components/memory_pressure/direct_memory_pressure_calculator.cc View 1 1 chunk +0 lines, -18 lines 0 comments Download
A + components/memory_pressure/direct_memory_pressure_calculator_win.h View 7 chunks +3 lines, -9 lines 0 comments Download
M components/memory_pressure/direct_memory_pressure_calculator_win.cc View 1 2 chunks +6 lines, -1 line 0 comments Download
M components/memory_pressure/direct_memory_pressure_calculator_win_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 18 (11 generated)
Georges Khalil
Chris, PTAL. Do we have a tracking bug for the memory pressure stuff?
4 years, 11 months ago (2016-01-11 18:38:30 UTC) #2
chrisha
lgtm!
4 years, 11 months ago (2016-01-11 19:02:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1573123003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1573123003/1
4 years, 11 months ago (2016-01-11 19:05:36 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_compile_dbg_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_compile_dbg_ng/builds/129651)
4 years, 11 months ago (2016-01-11 19:26:50 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1573123003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1573123003/40001
4 years, 11 months ago (2016-01-11 21:06:11 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 11 months ago (2016-01-11 22:23:10 UTC) #16
commit-bot: I haz the power
4 years, 11 months ago (2016-01-11 22:24:18 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a92e2bc86dd9b73f497b05209a3112ae163079fa
Cr-Commit-Position: refs/heads/master@{#368691}

Powered by Google App Engine
This is Rietveld 408576698