Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Unified Diff: win8/viewer/metro_viewer_process_host.h

Issue 15731003: Make the browser->metro_viewer IPC channel name a constant instead of hardcoding it in a few places… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Wrap command_execute_impl.cc::LaunchChromeBrowserProcess() in USE_AURA if defs to fix non-aura comp… Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: win8/viewer/metro_viewer_process_host.h
diff --git a/win8/viewer/metro_viewer_process_host.h b/win8/viewer/metro_viewer_process_host.h
index 288a320eefbceb1ff22725389a36305397e35818..c846d134cdac7e3be5dd599b061c906417015a55 100644
--- a/win8/viewer/metro_viewer_process_host.h
+++ b/win8/viewer/metro_viewer_process_host.h
@@ -5,8 +5,6 @@
#ifndef WIN8_VIEWER_METRO_VIEWER_PROCESS_HOST_H_
#define WIN8_VIEWER_METRO_VIEWER_PROCESS_HOST_H_
-#include <string>
-
#include "base/basictypes.h"
#include "base/memory/scoped_ptr.h"
#include "base/strings/string16.h"
@@ -32,13 +30,13 @@ class MetroViewerProcessHost : public IPC::Listener,
public IPC::Sender,
public base::NonThreadSafe {
public:
- // Initializes a viewer process host over |ipc_channel_name|. The given task
- // runner correspond to a thread on which IPC::Channel is created and used
- // (e.g. IO thread). Instantly connects to the viewer process if one is
- // already connected to |ipc_channel_name|; a viewer can otherwise be
- // launched synchronously via LaunchViewerAndWaitForConnection().
- MetroViewerProcessHost(const std::string& ipc_channel_name,
- base::SingleThreadTaskRunner* ipc_task_runner);
+ // Initializes a viewer process host to connect to the Metro viewer process
+ // over IPC. The given task runner correspond to a thread on which
+ // IPC::Channel is created and used (e.g. IO thread). Instantly connects to
+ // the viewer process if one is already connected to |ipc_channel_name|; a
+ // viewer can otherwise be launched synchronously via
+ // LaunchViewerAndWaitForConnection().
+ MetroViewerProcessHost(base::SingleThreadTaskRunner* ipc_task_runner);
virtual ~MetroViewerProcessHost();
// Returns the process id of the viewer process if one is connected to this

Powered by Google App Engine
This is Rietveld 408576698