chrome/browser/browser_process_platform_part_aurawin.cc - Issue 15731003: Make the browser->metro_viewer IPC channel name a constant instead of hardcoding it in a few places…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/browser_process_platform_part_aurawin.cc

Issue 15731003: Make the browser->metro_viewer IPC channel name a constant instead of hardcoding it in a few places… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Wrap command_execute_impl.cc::LaunchChromeBrowserProcess() in USE_AURA if defs to fix non-aura comp… Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« ash/test/test_metro_viewer_process_host.h ('K') | « ash/test/test_metro_viewer_process_host.cc ('k') | chrome/browser/metro_viewer/chrome_metro_viewer_process_host_aurawin.h » ('j') | chrome/browser/metro_viewer/chrome_metro_viewer_process_host_aurawin.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/browser_process_platform_part_aurawin.cc

diff --git a/chrome/browser/browser_process_platform_part_aurawin.cc b/chrome/browser/browser_process_platform_part_aurawin.cc

index e6be06dd24c062da2c72692ac30e9c84372a7d02..8299d01a3347fe8b7e997b74206070c07948ae07 100644

--- a/chrome/browser/browser_process_platform_part_aurawin.cc

+++ b/chrome/browser/browser_process_platform_part_aurawin.cc

@@ -25,12 +25,10 @@ void BrowserProcessPlatformPart::OnMetroViewerProcessTerminated() {

void BrowserProcessPlatformPart::PlatformSpecificCommandLineProcessing(

const CommandLine& command_line) {

if (base::win::GetVersion() >= base::win::VERSION_WIN8 &&

- command_line.HasSwitch(switches::kViewerConnection) &&

+ command_line.HasSwitch(switches::kViewerConnect) &&

!metro_viewer_process_host_.get()) {

- // Tell the metro viewer process host to connect to the given IPC channel.

- metro_viewer_process_host_.reset(

- new ChromeMetroViewerProcessHost(

- command_line.GetSwitchValueASCII(switches::kViewerConnection)));

+ // Create a host to connect to the Metro viewer process over IPC.

+ metro_viewer_process_host_.reset(new ChromeMetroViewerProcessHost());

}