Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1573053003:
[wasm] Fix set_local appearing in unreachable code. (Closed)
Description[wasm] Fix set_local appearing in unreachable code.
R=ahaas@chromium.org
LOG=Y
BUG=chromium:575861
Committed: https://crrev.com/391517ea993a7de8caeaec53bcfbaadb352f0bab
Cr-Commit-Position: refs/heads/master@{#33213}
Patch Set 1 #
Total comments: 1
Patch Set 2 : #
Messages
Total messages: 22 (11 generated)
lgtm https://codereview.chromium.org/1573053003/diff/1/test/cctest/wasm/test-run-w... File test/cctest/wasm/test-run-wasm.cc (right): https://codereview.chromium.org/1573053003/diff/1/test/cctest/wasm/test-run-w... test/cctest/wasm/test-run-wasm.cc:1690: BUILD(r, WASM_BLOCK(2, WASM_RETURN(WASM_ZERO), WASM_SET_LOCAL(0, WASM_ZERO))); Nit: Maybe we could return a magic number instead of zero, just to avoid accidental passes.
The CQ bit was checked by titzer@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1573053003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1573053003/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/9613)
Description was changed from ========== [wasm] Fix set_local appearing in unreachable code. R=ahaas@chromium.org BUG=chromium:575861 ========== to ========== [wasm] Fix set_local appearing in unreachable code. R=ahaas@chromium.org LOG=Y BUG=chromium:575861 ==========
The CQ bit was checked by titzer@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1573053003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1573053003/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: v8_linux64_avx2_rel on tryserver.v8 (JOB_TIMED_OUT, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel/builds/...) v8_linux_arm64_rel on tryserver.v8 (JOB_TIMED_OUT, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel/builds/1...) v8_mac_rel on tryserver.v8 (JOB_TIMED_OUT, http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel/builds/13906)
The CQ bit was checked by titzer@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1573053003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1573053003/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: v8_linux_dbg on tryserver.v8 (JOB_TIMED_OUT, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg/builds/12801)
The CQ bit was checked by titzer@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from ahaas@chromium.org Link to the patchset: https://codereview.chromium.org/1573053003/#ps20001 (title: " ")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1573053003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1573053003/20001
Message was sent while issue was closed.
Description was changed from ========== [wasm] Fix set_local appearing in unreachable code. R=ahaas@chromium.org LOG=Y BUG=chromium:575861 ========== to ========== [wasm] Fix set_local appearing in unreachable code. R=ahaas@chromium.org LOG=Y BUG=chromium:575861 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== [wasm] Fix set_local appearing in unreachable code. R=ahaas@chromium.org LOG=Y BUG=chromium:575861 ========== to ========== [wasm] Fix set_local appearing in unreachable code. R=ahaas@chromium.org LOG=Y BUG=chromium:575861 Committed: https://crrev.com/391517ea993a7de8caeaec53bcfbaadb352f0bab Cr-Commit-Position: refs/heads/master@{#33213} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/391517ea993a7de8caeaec53bcfbaadb352f0bab Cr-Commit-Position: refs/heads/master@{#33213} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
