Fix jar_toc.py to include public/protected methods

Fix jar_toc.py to include public/protected methods

Otherwise a method-only change does not cause dependent jars to be
rebuilt.

Committed: https://crrev.com/1b4abd14aae0fcffc65b96a5fa6554290386cc4b
Cr-Commit-Position: refs/heads/master@{#368604}

[boliu, 2016-01-11 02:26:29]

boliu@chromium.org changed reviewers:
+ jbudorick@chromium.org

[boliu, 2016-01-11 02:26:29]

covers public+protected members+fields. I probably didn't try all the different
signature combinations there is to try, but at least this is a definite
improvement..

Not sure why anything package-visible should be included though..

[jbudorick, 2016-01-11 14:42:30]

On 2016/01/11 02:26:29, boliu wrote:
> covers public+protected members+fields. I probably didn't try all the
different
> signature combinations there is to try, but at least this is a definite
> improvement..

Agreed, it is. Thanks for looking at this. lgtm

> 
> Not sure why anything package-visible should be included though..

I would guess for tests, which is the only situation I can think of where
classes in the same package would be in two different targets.

[boliu, 2016-01-11 15:41:27]

The CQ bit was checked by boliu@chromium.org

[commit-bot: I haz the power, 2016-01-11 15:41:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1573023002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1573023002/1

[commit-bot: I haz the power, 2016-01-11 16:54:32]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-01-11 16:55:40]

Description was changed from

==========
Fix jar_toc.py to include public/protected methods

Otherwise a method-only change does not cause dependent jars to be
rebuilt.
==========

to

==========
Fix jar_toc.py to include public/protected methods

Otherwise a method-only change does not cause dependent jars to be
rebuilt.

Committed: https://crrev.com/1b4abd14aae0fcffc65b96a5fa6554290386cc4b
Cr-Commit-Position: refs/heads/master@{#368604}
==========

[commit-bot: I haz the power, 2016-01-11 16:55:41]

Patchset 1 (id:??) landed as
https://crrev.com/1b4abd14aae0fcffc65b96a5fa6554290386cc4b
Cr-Commit-Position: refs/heads/master@{#368604}

[boliu, 2016-01-11 17:09:39]

On 2016/01/11 14:42:30, jbudorick wrote:
> On 2016/01/11 02:26:29, boliu wrote:
> > covers public+protected members+fields. I probably didn't try all the
> different
> > signature combinations there is to try, but at least this is a definite
> > improvement..
> 
> Agreed, it is. Thanks for looking at this. lgtm
> 
> > 
> > Not sure why anything package-visible should be included though..
> 
> I would guess for tests, which is the only situation I can think of where
> classes in the same package would be in two different targets.

package visible methods don't have a prefix to grep for. Best thing I came up
with this:
'^  \w+.*;$'

WDYT?

Another question. Is there a reasonable way to write a test for this that runs
on cq?