Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issue 1573013002: Fix a race in HandleWatcherTest and remove suppression. (Closed)

Created:
4 years, 11 months ago by Anand Mistry (off Chromium)
Modified:
4 years, 11 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix a race in HandleWatcherTest and remove suppression. BUG=455665 Committed: https://crrev.com/624f51b77ff5583f00dff0cdddd286a4192aebfb Cr-Commit-Position: refs/heads/master@{#369974}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -6 lines) Patch
M build/sanitizers/tsan_suppressions.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M mojo/message_pump/handle_watcher_unittest.cc View 4 chunks +11 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
Anand Mistry (off Chromium)
4 years, 11 months ago (2016-01-11 01:53:26 UTC) #2
Anand Mistry (off Chromium)
And if you're wondering why I'm bothering, lets just say it's a side project of ...
4 years, 11 months ago (2016-01-11 02:14:29 UTC) #3
jam
sky would be a better reviewer than me
4 years, 11 months ago (2016-01-11 16:55:59 UTC) #5
sky
LGTM
4 years, 11 months ago (2016-01-11 17:22:04 UTC) #6
Anand Mistry (off Chromium)
glider: For OWNERS to remove suppression.
4 years, 11 months ago (2016-01-11 20:52:34 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1573013002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1573013002/1
4 years, 11 months ago (2016-01-18 00:01:24 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-18 00:32:55 UTC) #11
commit-bot: I haz the power
4 years, 11 months ago (2016-01-18 00:33:49 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/624f51b77ff5583f00dff0cdddd286a4192aebfb
Cr-Commit-Position: refs/heads/master@{#369974}

Powered by Google App Engine
This is Rietveld 408576698