cc: Refactor WorkerPoolTaskClient::AcquireBufferForRaster

cc/resources/raster_worker_pool.h

Index: cc/resources/raster_worker_pool.h
diff --git a/cc/resources/raster_worker_pool.h b/cc/resources/raster_worker_pool.h
index 81a9f9ac27fa5fec03f73d6a6076c82c5f47ee93..6439a9b7c5af99857c02b018c3a76d89169921ff 100644
--- a/cc/resources/raster_worker_pool.h
+++ b/cc/resources/raster_worker_pool.h
@@ -31,8 +31,7 @@ class RasterWorkerPoolTask;
 
 class CC_EXPORT WorkerPoolTaskClient {
  public:
-  virtual void* AcquireBufferForRaster(RasterWorkerPoolTask* task,
-                                       int* stride) = 0;
+  virtual SkCanvas* AcquireCanvasForRaster(RasterWorkerPoolTask* task) = 0;

[reveman, 2014/02/11 02:00:44]

I'd like to see this take a basic WorkerPoolTask* in the future and eliminate
the need for both a RasterWorkerPoolTask and a WorkerPoolTask class. You don't
have to change that in this patch but it would be nice if it lined up with that
idea.

The result is that the WorkerPoolTaskClient doesn't know much about the task.
ie. it can't call use_gpu_rasterization(). The decision to use gpu raster would
instead have to be driven by the task.

So maybe we could make this:

virtual SkCanvas* AcquireCanvasForRaster(const WorkerPoolTask* task,
                                         const Resource* resource,
                                         bool use_gpu_rasterization);

And I think OnRasterCompleted should be removed altogether but we could keep it
as:

virtual void OnRasterCompleted(internal::WorkerPoolTask* task,
                               const Resource* resource,
                               const PicturePileImpl::Analysis&,
                               bool use_gpu_rasterization);

for now.

[alokp, 2014/02/11 07:05:21]

Sure. This can be easily done when you decide to actually change
RasterWorkerPoolTask to WorkerPoolTask.

   virtual void OnRasterCompleted(RasterWorkerPoolTask* task,
                                  const PicturePileImpl::Analysis& analysis) = 0;
   virtual void OnImageDecodeCompleted(WorkerPoolTask* task) = 0;
@@ -218,6 +217,13 @@ class CC_EXPORT RasterWorkerPool : public internal::WorkerPoolTaskClient {
       RenderingStatsInstrumentation* rendering_stats,
       const Task::Reply& reply);
 
+  // Overridden from internal::WorkerPoolTaskClient:
+  virtual SkCanvas* AcquireCanvasForRaster(internal::RasterWorkerPoolTask* task)
+      OVERRIDE;
+  virtual void OnRasterCompleted(internal::RasterWorkerPoolTask* task,
+                                 const PicturePileImpl::Analysis& analysis)
+      OVERRIDE;
+
   void SetClient(RasterWorkerPoolClient* client);
 
   // Tells the worker pool to shutdown after canceling all previously