Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(478)

Issue 1572773002: Use better algorithm to scale browser action icons (Closed)

Created:
4 years, 11 months ago by Evan Stade
Modified:
4 years, 11 months ago
Reviewers:
Jun Mukai, benwells, oshima
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, rsesek+watch_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use better algorithm to scale browser action icons BUG=546206 Committed: https://crrev.com/6f65e10046c2f5e56ab4cf0b5dbe9962753542f6 Cr-Commit-Position: refs/heads/master@{#368998}

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : revert unintentional change #

Patch Set 4 : i stepped in a rabbit hole (not for review) #

Patch Set 5 : just on md #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -2 lines) Patch
M chrome/browser/ui/extensions/icon_with_badge_image_source.cc View 1 2 3 4 2 chunks +20 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
Evan Stade
I believe this wouldn't be necessary if this TODO[1] were fixed. Since I just copied ...
4 years, 11 months ago (2016-01-08 23:55:00 UTC) #2
Jun Mukai
lgtm That TODO would be addressed by oshima, but I think it won't happen anytime ...
4 years, 11 months ago (2016-01-11 18:33:25 UTC) #3
Evan Stade
+benwells for owner review
4 years, 11 months ago (2016-01-11 18:39:13 UTC) #5
oshima
lgtm
4 years, 11 months ago (2016-01-11 19:38:19 UTC) #6
benwells
stamp lgtm
4 years, 11 months ago (2016-01-12 02:46:29 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1572773002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1572773002/80001
4 years, 11 months ago (2016-01-12 21:03:09 UTC) #10
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 11 months ago (2016-01-12 22:07:18 UTC) #11
commit-bot: I haz the power
4 years, 11 months ago (2016-01-12 22:09:36 UTC) #13
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/6f65e10046c2f5e56ab4cf0b5dbe9962753542f6
Cr-Commit-Position: refs/heads/master@{#368998}

Powered by Google App Engine
This is Rietveld 408576698