QUIC - Allow cronet apps to specify how many server configs are to be

net/quic/quic_stream_factory.cc

Index: net/quic/quic_stream_factory.cc
diff --git a/net/quic/quic_stream_factory.cc b/net/quic/quic_stream_factory.cc
index e48985d2ef323b1bba210ba73b29e604b6ee6b6e..d33ea7ba72b68bad71b3d7719f33b3528533e61f 100644
--- a/net/quic/quic_stream_factory.cc
+++ b/net/quic/quic_stream_factory.cc
@@ -570,7 +570,7 @@ QuicStreamFactory::QuicStreamFactory(
     int threshold_timeouts_with_open_streams,
     int socket_receive_buffer_size,
     bool delay_tcp_race,
-    bool store_server_configs_in_properties,
+    int number_of_server_configs_stored_in_properties,
     bool close_sessions_on_ip_change,
     int idle_connection_timeout_seconds,
     const QuicTagVector& connection_options)
@@ -618,7 +618,8 @@ QuicStreamFactory::QuicStreamFactory(
       yield_after_packets_(kQuicYieldAfterPacketsRead),
       yield_after_duration_(QuicTime::Delta::FromMilliseconds(
           kQuicYieldAfterDurationMilliseconds)),
-      store_server_configs_in_properties_(store_server_configs_in_properties),
+      number_of_server_configs_stored_in_properties_(
+          number_of_server_configs_stored_in_properties),
       close_sessions_on_ip_change_(close_sessions_on_ip_change),
       port_seed_(random_generator_->RandUint64()),
       check_persisted_supports_quic_(true),
@@ -653,9 +654,11 @@ QuicStreamFactory::QuicStreamFactory(
   // When disk cache is used to store the server configs, HttpCache code calls
   // |set_quic_server_info_factory| if |quic_server_info_factory_| wasn't
   // created.
-  if (store_server_configs_in_properties_) {
+  if (number_of_server_configs_stored_in_properties_ > 0) {
     quic_server_info_factory_.reset(
         new PropertiesBasedQuicServerInfoFactory(http_server_properties_));
+    http_server_properties_->set_number_of_server_configs_stored_in_properties(
+        number_of_server_configs_stored_in_properties_);

[Ryan Hamilton, 2016/01/12 19:54:56]

I'm a bit surprised to see this code living in QuicStreamFactory. Is there a way
to do this logic directly in HttpServerProperties<something>

[ramant (doing other things), 2016/01/14 00:14:01]

Done.

   }
 
   if (close_sessions_on_ip_change_) {
@@ -1403,7 +1406,7 @@ void QuicStreamFactory::MaybeInitialize() {
     }
   }
 
-  if (!store_server_configs_in_properties_)
+  if (number_of_server_configs_stored_in_properties_ == 0)
     return;
   // Create a temporary QuicServerInfo object to deserialize and to populate the
   // in-memory crypto server config cache.