Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Unified Diff: net/quic/quic_stream_factory_test.cc

Issue 1572753003: QUIC - Allow cronet apps to specify how many server configs are to be (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix comments in Patch set 4 Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/quic_stream_factory.cc ('k') | net/url_request/url_request_context_builder.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/quic_stream_factory_test.cc
diff --git a/net/quic/quic_stream_factory_test.cc b/net/quic/quic_stream_factory_test.cc
index 1e1e1d6102f975dff66f9815b0499dd827d75b55..8754453ccabe455fd448e3ae9050d448b2fb7024 100644
--- a/net/quic/quic_stream_factory_test.cc
+++ b/net/quic/quic_stream_factory_test.cc
@@ -217,7 +217,6 @@ class QuicStreamFactoryTest : public ::testing::TestWithParam<TestParams> {
threshold_public_resets_post_handshake_(2),
receive_buffer_size_(0),
delay_tcp_race_(false),
- store_server_configs_in_properties_(false),
close_sessions_on_ip_change_(false),
idle_connection_timeout_seconds_(kIdleConnectionTimeoutSeconds),
migrate_sessions_on_network_change_(false) {
@@ -239,11 +238,13 @@ class QuicStreamFactoryTest : public ::testing::TestWithParam<TestParams> {
max_number_of_lossy_connections_, packet_loss_threshold_,
max_disabled_reasons_, threshold_timeouts_with_open_streams_,
threshold_public_resets_post_handshake_, receive_buffer_size_,
- delay_tcp_race_, store_server_configs_in_properties_,
+ delay_tcp_race_, /*max_server_configs_stored_in_properties*/ 0,
close_sessions_on_ip_change_, idle_connection_timeout_seconds_,
migrate_sessions_on_network_change_, QuicTagVector()));
factory_->set_require_confirmation(false);
+ EXPECT_FALSE(factory_->has_quic_server_info_factory());
factory_->set_quic_server_info_factory(new MockQuicServerInfoFactory());
+ EXPECT_TRUE(factory_->has_quic_server_info_factory());
}
void InitializeConnectionMigrationTest(
@@ -411,7 +412,6 @@ class QuicStreamFactoryTest : public ::testing::TestWithParam<TestParams> {
int threshold_public_resets_post_handshake_;
int receive_buffer_size_;
bool delay_tcp_race_;
- bool store_server_configs_in_properties_;
bool close_sessions_on_ip_change_;
int idle_connection_timeout_seconds_;
bool migrate_sessions_on_network_change_;
@@ -3099,7 +3099,6 @@ TEST_P(QuicStreamFactoryTest, EnableDelayTcpRace) {
}
TEST_P(QuicStreamFactoryTest, MaybeInitialize) {
- store_server_configs_in_properties_ = true;
idle_connection_timeout_seconds_ = 500;
Initialize();
ProofVerifyDetailsChromium verify_details = DefaultProofVerifyDetails();
@@ -3118,6 +3117,8 @@ TEST_P(QuicStreamFactoryTest, MaybeInitialize) {
http_server_properties_.SetAlternativeServices(
host_port_pair_, alternative_service_info_vector);
+ http_server_properties_.SetMaxServerConfigsStoredInProperties(
+ kMaxQuicServersToPersist);
QuicServerId quic_server_id(kDefaultServerHostName, 80,
PRIVACY_MODE_DISABLED);
« no previous file with comments | « net/quic/quic_stream_factory.cc ('k') | net/url_request/url_request_context_builder.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698