Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Unified Diff: components/cronet/url_request_context_config.cc

Issue 1572753003: QUIC - Allow cronet apps to specify how many server configs are to be (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix comments in Patch set 4 Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/cronet/url_request_context_config.cc
diff --git a/components/cronet/url_request_context_config.cc b/components/cronet/url_request_context_config.cc
index cb19efcf5b249211fc599d6597c0a15980860334..ca88279edc21a7a24a9d51353dc40122be977b2c 100644
--- a/components/cronet/url_request_context_config.cc
+++ b/components/cronet/url_request_context_config.cc
@@ -15,6 +15,7 @@
#include "base/values.h"
#include "net/cert/cert_verifier.h"
#include "net/dns/host_resolver.h"
+#include "net/http/http_server_properties.h"
#include "net/quic/quic_protocol.h"
#include "net/quic/quic_utils.h"
#include "net/url_request/url_request_context_builder.h"
@@ -28,6 +29,8 @@ const char kQuicFieldTrialName[] = "QUIC";
const char kQuicConnectionOptions[] = "connection_options";
const char kQuicStoreServerConfigsInProperties[] =
"store_server_configs_in_properties";
+const char kQuicMaxServerConfigsStoredInProperties[] =
+ "max_server_configs_stored_in_properties";
const char kQuicDelayTcpRace[] = "delay_tcp_race";
const char kQuicMaxNumberOfLossyConnections[] =
"max_number_of_lossy_connections";
@@ -76,11 +79,20 @@ void ParseAndSetExperimentalOptions(
net::QuicUtils::ParseQuicConnectionOptions(quic_connection_options));
}
+ // TODO(rtenneti): Delete this option after apps stop using it.
+ // Added this for backward compatibility.
bool quic_store_server_configs_in_properties = false;
if (quic_args->GetBoolean(kQuicStoreServerConfigsInProperties,
&quic_store_server_configs_in_properties)) {
- context_builder->set_quic_store_server_configs_in_properties(
- quic_store_server_configs_in_properties);
+ context_builder->set_quic_max_server_configs_stored_in_properties(
+ net::kMaxQuicServersToPersist);
+ }
+
+ int quic_max_server_configs_stored_in_properties = 0;
+ if (quic_args->GetInteger(kQuicMaxServerConfigsStoredInProperties,
+ &quic_max_server_configs_stored_in_properties)) {
+ context_builder->set_quic_max_server_configs_stored_in_properties(
+ static_cast<size_t>(quic_max_server_configs_stored_in_properties));
}
bool quic_delay_tcp_race = false;

Powered by Google App Engine
This is Rietveld 408576698