QUIC - Allow cronet apps to specify how many server configs are to be

net/http/http_network_session.cc

Index: net/http/http_network_session.cc
diff --git a/net/http/http_network_session.cc b/net/http/http_network_session.cc
index d3f73aa9dc9176759bfba24ac2518786a6dcfaaf..ad82f35f51d52821582a746ac7f2e779f8197f88 100644
--- a/net/http/http_network_session.cc
+++ b/net/http/http_network_session.cc
@@ -114,7 +114,7 @@ HttpNetworkSession::Params::Params()
       quic_packet_loss_threshold(1.0f),
       quic_socket_receive_buffer_size(kQuicSocketReceiveBufferSize),
       quic_delay_tcp_race(false),
-      quic_store_server_configs_in_properties(false),
+      quic_max_server_configs_stored_in_properties(0),

[mef, 2016/01/15 16:12:32]

BUG? 

See mru_cache.h:

  enum { NO_AUTO_EVICT = 0 };

If we default to 0, would it mean that we'll store unlimited number of server
configs? Is that what we expect?

[ramant (doing other things), 2016/01/15 18:57:00]

We create PropertiesBasedQuicServerInfoFactory only when 
quic_max_server_configs_stored_in_properties is not 0 in 
QuicStreamFactory::QuicStreamFactory.

We don't enable this feature unless we create
PropertiesBasedQuicServerInfoFactory object, otherwise we will use disk cache
based cache.


https://codereview.chromium.org/1572753003/diff/100001/net/quic/quic_stream_f...

We add entries to QuicServerInfoMap in the following code only when 
PropertiesBasedQuicServerInfo is created otherwise we choose
DiskCacheBasedQuicServerInfo.

https://code.google.com/p/chromium/codesearch#chromium/src/net/quic/crypto/pr...

https://code.google.com/p/chromium/codesearch#chromium/src/net/quic/crypto/pr...

If quic_max_server_configs_stored_in_properties > 0, then only we add entries
into the map, otherwise that map is not used.

[mef, 2016/01/15 20:01:36]

Thanks for the explanation! I think it is a bit confusing, but not broken.

       quic_clock(NULL),
       quic_random(NULL),
       quic_max_packet_length(kDefaultMaxPacketSize),
@@ -176,7 +176,7 @@ HttpNetworkSession::HttpNetworkSession(const Params& params)
           params.quic_threshold_timeouts_streams_open,
           params.quic_socket_receive_buffer_size,
           params.quic_delay_tcp_race,
-          params.quic_store_server_configs_in_properties,
+          params.quic_max_server_configs_stored_in_properties,
           params.quic_close_sessions_on_ip_change,
           params.quic_idle_connection_timeout_seconds,
           params.quic_migrate_sessions_on_network_change,
@@ -239,6 +239,8 @@ HttpNetworkSession::HttpNetworkSession(const Params& params)
 
   http_server_properties_->SetAlternativeServiceProbabilityThreshold(
       params.alternative_service_probability_threshold);
+  http_server_properties_->set_max_server_configs_stored_in_properties(

[mef, 2016/01/15 16:12:32]

There was no params.quic_store_server_configs_in_properties here before?

[ramant (doing other things), 2016/01/15 18:57:00]

This flag used to be saved in QuicStreamFactory.h and HttpServerProperties had a
hard coded size.

+      params.quic_max_server_configs_stored_in_properties);
 }
 
 HttpNetworkSession::~HttpNetworkSession() {
@@ -324,8 +326,8 @@ scoped_ptr<base::Value> HttpNetworkSession::QuicInfoToValue() const {
                    params_.quic_max_number_of_lossy_connections);
   dict->SetDouble("packet_loss_threshold", params_.quic_packet_loss_threshold);
   dict->SetBoolean("delay_tcp_race", params_.quic_delay_tcp_race);
-  dict->SetBoolean("store_server_configs_in_properties",
-                   params_.quic_store_server_configs_in_properties);
+  dict->SetInteger("max_server_configs_stored_in_properties",
+                   params_.quic_max_server_configs_stored_in_properties);
   dict->SetInteger("idle_connection_timeout_seconds",
                    params_.quic_idle_connection_timeout_seconds);
   dict->SetBoolean("disable_preconnect_if_0rtt",