QUIC - Allow cronet apps to specify how many server configs are to be

components/cronet/url_request_context_config.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/cronet/url_request_context_config.h"
 
 #include <utility>
 
 #include "base/json/json_reader.h"
 #include "base/logging.h"
@@ skipping 10 matching lines @@
 
 namespace cronet {
 
 namespace {
 
 // TODO(xunjieli): Refactor constants in io_thread.cc.
 const char kQuicFieldTrialName[] = "QUIC";
 const char kQuicConnectionOptions[] = "connection_options";
 const char kQuicStoreServerConfigsInProperties[] =
     "store_server_configs_in_properties";
+const char kQuicMaxServerConfigsStoredInProperties[] =
+    "max_server_configs_stored_in_properties";
 const char kQuicDelayTcpRace[] = "delay_tcp_race";
 const char kQuicMaxNumberOfLossyConnections[] =
     "max_number_of_lossy_connections";
 const char kQuicPacketLossThreshold[] = "packet_loss_threshold";
 const char kQuicIdleConnectionTimeoutSeconds[] =
     "idle_connection_timeout_seconds";
 const char kQuicHostWhitelist[] = "host_whitelist";
 
 // AsyncDNS experiment dictionary name.
 const char kAsyncDnsFieldTrialName[] = "AsyncDNS";
@@ skipping 28 matching lines @@
 
   const base::DictionaryValue* quic_args = nullptr;
   if (dict->GetDictionary(kQuicFieldTrialName, &quic_args)) {
     std::string quic_connection_options;
     if (quic_args->GetString(kQuicConnectionOptions,
                              &quic_connection_options)) {
       context_builder->set_quic_connection_options(
           net::QuicUtils::ParseQuicConnectionOptions(quic_connection_options));
     }
 
+    // TODO(rtenneti): Delete this option after apps stop using it.
+    // Added this for backward compatability.

[mef, 2016/01/15 16:12:32]

nit: compatability -> compatibility

[ramant (doing other things), 2016/01/15 18:57:00]

Done.

     bool quic_store_server_configs_in_properties = false;
     if (quic_args->GetBoolean(kQuicStoreServerConfigsInProperties,
                               &quic_store_server_configs_in_properties)) {
-      context_builder->set_quic_store_server_configs_in_properties(
-          quic_store_server_configs_in_properties);
+      context_builder->set_quic_max_server_configs_stored_in_properties(
+          net::kMaxQuicServersToPersist);

[mef, 2016/01/15 16:12:32]

#include "net/http/http_server_properties.h"

[ramant (doing other things), 2016/01/15 18:57:00]

Done.

+    }
+
+    int quic_max_server_configs_stored_in_properties = 0;
+    if (quic_args->GetInteger(kQuicMaxServerConfigsStoredInProperties,
+                              &quic_max_server_configs_stored_in_properties)) {
+      context_builder->set_quic_max_server_configs_stored_in_properties(
+          quic_max_server_configs_stored_in_properties);
     }
 
     bool quic_delay_tcp_race = false;
     if (quic_args->GetBoolean(kQuicDelayTcpRace, &quic_delay_tcp_race)) {
       context_builder->set_quic_delay_tcp_race(quic_delay_tcp_race);
     }
 
     int quic_max_number_of_lossy_connections = 0;
     if (quic_args->GetInteger(kQuicMaxNumberOfLossyConnections,
                               &quic_max_number_of_lossy_connections)) {
@@ skipping 119 matching lines @@
 
   ParseAndSetExperimentalOptions(experimental_options, context_builder,
                                  net_log);
 
   if (mock_cert_verifier)
     context_builder->SetCertVerifier(std::move(mock_cert_verifier));
   // TODO(mef): Use |config| to set cookies.
 }
 
 }  // namespace cronet