[PNaCl toolchain] Stop building and using custom libc++ for OSX hosts

[PNaCl toolchain] Stop building and using custom libc++ for OSX hosts

Our Mac buildbots recently started using a different SDK, and our local build
of libc++ doesn't work with that SDK. Instead of fixing it, we can just
use the libc++ that recently started shipping with the clang we use to
build the toolchain (and Chrome).
So on Mac hosts, continue using the -stdlib=libc++ flag, but do not build,
use, or upload our local libc++.

R=mcgrathr@chromium.org, stichnot@chromium.org

Committed: https://chromium.googlesource.com/native_client/src/native_client/+/a1f591d21f3989e78f7805d7d2d92e6fb3a3f2a4

[Derek Schuff, 2016-01-08 23:05:45]

This should fix the mac buildbots.

[Roland McGrath, 2016-01-08 23:09:27]

lgtm

https://codereview.chromium.org/1572753002/diff/1/toolchain_build/toolchain_b...
File toolchain_build/toolchain_build_pnacl.py (right):

https://codereview.chromium.org/1572753002/diff/1/toolchain_build/toolchain_b...
toolchain_build/toolchain_build_pnacl.py:280: # Use our own libc++ on Linux
TODO here about using chromium-built libc++-static for Linux too (and getting
chromium to build it for Linux).

[Derek Schuff, 2016-01-08 23:30:37]

https://codereview.chromium.org/1572753002/diff/1/toolchain_build/toolchain_b...
File toolchain_build/toolchain_build_pnacl.py (right):

https://codereview.chromium.org/1572753002/diff/1/toolchain_build/toolchain_b...
toolchain_build/toolchain_build_pnacl.py:280: # Use our own libc++ on Linux
On 2016/01/08 23:09:27, Roland McGrath wrote:
> TODO here about using chromium-built libc++-static for Linux too (and getting
> chromium to build it for Linux).

Done.

[Derek Schuff, 2016-01-08 23:48:12]

Description was changed from

==========
[PNaCl toolchain] Stop building and using custom libc++ for OSX hosts

Our Mac buildbots recently started using a different SDK, and our local build
of libc++ doesn't work with that SDK. Instead of fixing it, we can just
use the libc++ that recently started shipping with the clang we use to
build the toolchain (and Chrome).
So on Mac hosts, continue using the -stdlib=libc++ flag, but do not build,
use, or upload our local libc++.

R=mcgrathr@chromium.org,stichnot@chromium.org
==========

to

==========
[PNaCl toolchain] Stop building and using custom libc++ for OSX hosts

Our Mac buildbots recently started using a different SDK, and our local build
of libc++ doesn't work with that SDK. Instead of fixing it, we can just
use the libc++ that recently started shipping with the clang we use to
build the toolchain (and Chrome).
So on Mac hosts, continue using the -stdlib=libc++ flag, but do not build,
use, or upload our local libc++.

R=mcgrathr@chromium.org, stichnot@chromium.org

Committed:
https://chromium.googlesource.com/native_client/src/native_client/+/a1f591d21...
==========

[Derek Schuff, 2016-01-08 23:48:13]

Committed patchset #2 (id:20001) manually as
a1f591d21f3989e78f7805d7d2d92e6fb3a3f2a4 (presubmit successful).

[Mark Seaborn, 2016-01-14 16:31:32]

It looks like this causes the PNaCl/LLVM tools to stop working on Mac OS X 10.6,
which broke nacl_integration on Chromium's OS X 10.6 bots.

That caused this DEPS roll to be reverted:
https://codereview.chromium.org/1580293003/

Probably the best thing to do here is to disable nacl_integration on OS X 10.6
at least.

[Roland McGrath, 2016-01-14 16:45:11]

I thought the plan here had always been to use the libc++-static built by
Chromium.
We should not be adding host system requirements to the toolchain lightly.

[native-client-reviews_googlegroups.com, 2016-01-14 16:54:06]

I guess that is why the suggested solution is to disable nacl_integration
rather than change the build? That seems fine to me; OSX 10.6 support is
going away for Chrome soon anyway. It is odd because I had thought that we
were using the -macosx-version-min=10.6 (or however it's spelled) for our
build but it's probably not worth looking into (other than maybe ensuring
that it actually works on 10.9 so it matches Chrome).

On Thu, Jan 14, 2016 at 8:45 AM <mcgrathr@chromium.org> wrote:

> I thought the plan here had always been to use the libc++-static built by
> Chromium.
> We should not be adding host system requirements to the toolchain lightly.
>
> https://codereview.chromium.org/1572753002/
>
> --
> You received this message because you are subscribed to the Google Groups
> "Native-Client-Reviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to native-client-reviews+unsubscribe@googlegroups.com.
> To post to this group, send email to
> native-client-reviews@googlegroups.com.
> Visit this group at https://groups.google.com/group/native-client-reviews.
> For more options, visit https://groups.google.com/d/optout.
>

-- 
You received this message because you are subscribed to the Google Groups
"Native-Client-Reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to native-client-reviews+unsubscribe@googlegroups.com.
To post to this group, send email to native-client-reviews@googlegroups.com.
Visit this group at https://groups.google.com/group/native-client-reviews.
For more options, visit https://groups.google.com/d/optout.

[Derek Schuff, 2016-01-20 17:44:36]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1608263003/ by dschuff@chromium.org.

The reason for reverting is: This patch (as-is) causes a dependency on the
system libc++ which breaks the toolchain on OSX.
I have a better (for the short term) fix for this..