Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2088)

Unified Diff: content/public/test/test_renderer_host.h

Issue 1572743002: Make sure bubbles in Views default to close before their RenderFrameHosts. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@lkcr
Patch Set: Move DCHECK string into longer comment Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/bubble/bubble_manager_unittest.cc ('k') | content/test/test_render_frame_host.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/public/test/test_renderer_host.h
diff --git a/content/public/test/test_renderer_host.h b/content/public/test/test_renderer_host.h
index fae14cea14b76b4aaf6e30d4746f4da8f678e5a7..062c642be91930d4e5305cd31cd56ff6a4da8380 100644
--- a/content/public/test/test_renderer_host.h
+++ b/content/public/test/test_renderer_host.h
@@ -79,6 +79,9 @@ class RenderFrameHostTester {
// RenderFrameHost is owned by the parent RenderFrameHost.
virtual RenderFrameHost* AppendChild(const std::string& frame_name) = 0;
+ // Gives tests access to RenderFrameHostImpl::OnDetach. Destroys |this|.
+ virtual void Detach() = 0;
+
// Simulates a renderer-initiated navigation to |url| starting in the
// RenderFrameHost.
virtual void SimulateNavigationStart(const GURL& url) = 0;
« no previous file with comments | « components/bubble/bubble_manager_unittest.cc ('k') | content/test/test_render_frame_host.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698