Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Unified Diff: components/bubble/bubble_manager_mocks.cc

Issue 1572743002: Make sure bubbles in Views default to close before their RenderFrameHosts. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@lkcr
Patch Set: Move DCHECK string into longer comment Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/bubble/bubble_manager_mocks.h ('k') | components/bubble/bubble_manager_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/bubble/bubble_manager_mocks.cc
diff --git a/components/bubble/bubble_manager_mocks.cc b/components/bubble/bubble_manager_mocks.cc
index 067e5f3be0682d8a83341d243ab109e12978a28a..7bec6792c28498d3f2e2639f0898cd2c8512dd69 100644
--- a/components/bubble/bubble_manager_mocks.cc
+++ b/components/bubble/bubble_manager_mocks.cc
@@ -16,7 +16,8 @@ MockBubbleDelegate::~MockBubbleDelegate() { Destroyed(); }
scoped_ptr<MockBubbleDelegate> MockBubbleDelegate::Default() {
MockBubbleDelegate* delegate = new MockBubbleDelegate;
EXPECT_CALL(*delegate, ShouldClose(testing::_))
- .WillOnce(testing::Return(true));
+ .Times(testing::AtMost(1))
+ .WillRepeatedly(testing::Return(true));
EXPECT_CALL(*delegate, DidClose());
EXPECT_CALL(*delegate, Destroyed());
return make_scoped_ptr(delegate);
« no previous file with comments | « components/bubble/bubble_manager_mocks.h ('k') | components/bubble/bubble_manager_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698