chrome/browser/ui/bluetooth/bluetooth_chooser_bubble_delegate.cc - Issue 1572743002: Make sure bubbles in Views default to close before their RenderFrameHosts.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/bluetooth/bluetooth_chooser_bubble_delegate.cc

Issue 1572743002: Make sure bubbles in Views default to close before their RenderFrameHosts. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@lkcr

Patch Set: Move DCHECK string into longer comment Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/bluetooth/bluetooth_chooser_bubble_delegate.cc

diff --git a/chrome/browser/ui/bluetooth/bluetooth_chooser_bubble_delegate.cc b/chrome/browser/ui/bluetooth/bluetooth_chooser_bubble_delegate.cc

index 8ca66407287cfea142d9fb79fb54da8fa20a6832..7db53f219718fc244b83ae32966e3166541fc39e 100644

--- a/chrome/browser/ui/bluetooth/bluetooth_chooser_bubble_delegate.cc

+++ b/chrome/browser/ui/bluetooth/bluetooth_chooser_bubble_delegate.cc

@@ -8,8 +8,9 @@

#include "chrome/browser/ui/bluetooth/bluetooth_chooser_desktop.h"

#include "components/bubble/bubble_controller.h"

-BluetoothChooserBubbleDelegate::BluetoothChooserBubbleDelegate(Browser* browser)

- : ChooserBubbleDelegate(browser), bluetooth_chooser_(nullptr) {}

+BluetoothChooserBubbleDelegate::BluetoothChooserBubbleDelegate(

+ content::RenderFrameHost* owner)

+ : ChooserBubbleDelegate(owner), bluetooth_chooser_(nullptr) {}

BluetoothChooserBubbleDelegate::~BluetoothChooserBubbleDelegate() {

if (bluetooth_chooser_)

« no previous file with comments | « chrome/browser/ui/bluetooth/bluetooth_chooser_bubble_delegate.h ('k') | chrome/browser/ui/browser.cc » ('j') | no next file with comments »