Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2005)

Unified Diff: content/test/test_render_frame_host.cc

Issue 1572743002: Make sure bubbles in Views default to close before their RenderFrameHosts. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@lkcr
Patch Set: Add a test and only allow one filter in CloseAllMatchingBubbles. Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/test/test_render_frame_host.cc
diff --git a/content/test/test_render_frame_host.cc b/content/test/test_render_frame_host.cc
index 86944830c772f136d0177dd673d6e1c93b57a8e3..6c486045cfeee96b13729c86fbe1f01db84e7997 100644
--- a/content/test/test_render_frame_host.cc
+++ b/content/test/test_render_frame_host.cc
@@ -90,6 +90,10 @@ TestRenderFrameHost* TestRenderFrameHost::AppendChild(
child_creation_observer_.last_created_frame());
}
+void TestRenderFrameHost::Detach() {
+ OnDetach();
+}
+
void TestRenderFrameHost::SimulateNavigationStart(const GURL& url) {
if (IsBrowserSideNavigationEnabled()) {
SendRendererInitiatedNavigationRequest(url, false);

Powered by Google App Engine
This is Rietveld 408576698