Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: tools/metrics/histograms/histograms.xml

Issue 1572743002: Make sure bubbles in Views default to close before their RenderFrameHosts. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@lkcr
Patch Set: Clean up Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
« components/bubble/bubble_manager.cc ('K') | « components/bubble/bubble_manager_mocks.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/metrics/histograms/histograms.xml
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
index 80cfbc7de7b75335eeb51c86416f5d71150721f6..2535790e0325b621914680fc155a9a04cf99d1d8 100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -3728,6 +3728,11 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
<summary>An open bubble was forced to close.</summary>
</histogram>
+<histogram name="Bubbles.Close.FrameDestroyed" enum="BubbleType">
+ <owner>hcarmona@chromium.org</owner>
+ <summary>An open bubble was dismissed because a frame was destroyed.</summary>
+</histogram>
+
<histogram name="Bubbles.Close.FullscreenToggled" enum="BubbleType">
<owner>hcarmona@chromium.org</owner>
<summary>
« components/bubble/bubble_manager.cc ('K') | « components/bubble/bubble_manager_mocks.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698