Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Unified Diff: components/bubble/bubble_manager.h

Issue 1572743002: Make sure bubbles in Views default to close before their RenderFrameHosts. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@lkcr
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/bubble/bubble_manager.h
diff --git a/components/bubble/bubble_manager.h b/components/bubble/bubble_manager.h
index 3e2d838f8902dc708ad4482302665377f02fe069..6b9dced8cf7b2c714baeb699d729d63d78506ac5 100644
--- a/components/bubble/bubble_manager.h
+++ b/components/bubble/bubble_manager.h
@@ -47,6 +47,8 @@ class BubbleManager {
// Shows a specific bubble and returns a reference to it.
// This reference should be used through the BubbleManager.
+ // Unless the BubbleDelegate uses ShouldClose to override the default, the
+ // BubbleDelegate will be destroyed before any RenderFrameHost is destroyed.
hcarmona 2016/01/11 19:07:22 Same concern as above about this being very specif
BubbleReference ShowBubble(scoped_ptr<BubbleDelegate> bubble);
// Notify a bubble of an event that might trigger close.

Powered by Google App Engine
This is Rietveld 408576698