Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(242)

Unified Diff: tools/metrics/histograms/histograms.xml

Side-by-side diff isn't available for this file because of its large size.
Issue 1572743002: Make sure bubbles in Views default to close before their RenderFrameHosts. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@lkcr
Patch Set: Move DCHECK string into longer comment Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
« no previous file with comments | « content/test/test_render_frame_host.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/metrics/histograms/histograms.xml
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
index e438bcd29287db560776ec9f81e915f5283a3edd..2c021ff71f907e3c6ef95c42d0d63486b17e3666 100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -3728,6 +3728,11 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
<summary>An open bubble was forced to close.</summary>
</histogram>
+<histogram name="Bubbles.Close.FrameDestroyed" enum="BubbleType">
+ <owner>hcarmona@chromium.org</owner>
+ <summary>An open bubble was dismissed because a frame was destroyed.</summary>
+</histogram>
+
<histogram name="Bubbles.Close.FullscreenToggled" enum="BubbleType">
<owner>hcarmona@chromium.org</owner>
<summary>
« no previous file with comments | « content/test/test_render_frame_host.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698